From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD22296BC1 for ; Thu, 21 May 2026 07:40:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779349217; cv=none; b=oNU19vU6ny/D7IaGD268byTbMi6ONceTT8UDqm35rxVSdc5M/hoTv1pELUCLN0e2cngIXcQgmTQpmpNyt+XMlt+xj12+3c7qzMSW4udyDKXO4kIvXQ8Wda2aJ50Bzv5sKS41EIZ8DqjqKlTqKhL9YK9aoyJo5tmGq6XkwdbDF4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779349217; c=relaxed/simple; bh=mnp0hDUMzsfuD8bK3qz6ZH9GHD+w1suz58/r0pz4j0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K8Xmkm9DvVNbxbNcZ7plEUy5JIh1iwdeKYexTS87nhLod6DtFMT/4JTajtW7nQkvmHhGdIR5SO3D46P2v2GC0BWNKF/CArjq7HhFiIaDPnjfYtxNahQD0fepRNVYaq0ySzfmPQV0Bkp+T1jdg9BTxC5XqJVqt4cc6O0tCcFGnug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EdgJ7aKe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K7hKTzeU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EdgJ7aKe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K7hKTzeU" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L6x9dR118975 for ; Thu, 21 May 2026 07:40:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zJVuFDQsF4Iwfpmap+pWFBw4cYfM0g67R2E4BQtznhI=; b=EdgJ7aKe0dbx0o9S oswDIcris1MmJIdTlkWGyqwXmEyMm/3+tcV0c8RVBba2keOATX6VY1IK7+RhInKX 68T0EmvjiVGxca3xv3eZLnruWsOkpD8IaTEebkgqbmb2gJI/DRPlOxka8RpPltRx kn8eJOm2v7YhxVfCX/7nVahcBv8XmSQASVDC8Jdk7bun1eBRHu6UII+Q/SfmIIJm 8tuT2Hf/2AdyVCxdYCK2dUIiLdAFLLUI7zI7M/IyZCV/KH68mC0Z5T9NjJgCdK/m g0dbgmfs1x/0/vVsQxUAqDxXjW0K/cZ8PgWFUtvkpejH2LFhWivsL+vAMPCwqp7z gqQU3A== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ee8bs0k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 07:40:14 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82f6e6a3a76so7879295b3a.0 for ; Thu, 21 May 2026 00:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779349214; x=1779954014; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zJVuFDQsF4Iwfpmap+pWFBw4cYfM0g67R2E4BQtznhI=; b=K7hKTzeUefitX8Niim8JrJK3puF/pQ7MiQHQyCdu7F3jp3CdNxH986I88wTBCt9osI N36s3uP6RIXeWvokNLenBFtKNiKJKyCDHVclAlHGpRRF2DuQ2f7TLmVixzOY+APyc2aL yk1bxMxrTYYoRudED3yVz6+YuyCoupo9zzwo3TXXVXJJ4NIvPeKtCRLF7GMwMAhNBgnx CAkEbeDhI/uafbMYA2JKZlzm9pHxJs+3v7Is/pnj0e5vbypY+LISK+HKnUr3LcXBLhHw dqXGi8bLJEBEJJ+MgKcM4I4JgiyJwnQkkKVZnEd+LXR2TuR98/JqTmmjLO1iWRnk8zxe cDAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779349214; x=1779954014; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zJVuFDQsF4Iwfpmap+pWFBw4cYfM0g67R2E4BQtznhI=; b=cwzxkJZ9BlAq28myffAIESMuvVg4sFtA6OL+CASFE++0eFZKZvy6a9OcTTwIgiDl/3 3sBT6kMjLCjawXd90uhFwUvKYM/of4lj6jv/4jddquyN/LpNYLHiLifOrLELs9fzcjw8 Ng7cJiEHavwVWAemyA9mQDkzelJPPd1qqLt5TqTnHcfaphIVIOIrSmAlZCTn3DU0Asb0 Bhavz8YMxG6FkQJi/0o8Rpy5PkC8TH60xNr1wmZlHHU7z2BX4xPQntBHMBVIYOrF1VWj 7d24GH7au8EmgmCSYU+Jxw+rLuvzNdXiLTGFJY+/kVbhu4eeyyOl6nLS5GCcE0DnJEEI f5dA== X-Forwarded-Encrypted: i=1; AFNElJ/Ka8i9Sz/ILsPcJo2w5XLcKmBMkZ3gth9e69eLJ9DRGOhvYHyBM/AZAlXEFweSCmFppNV1XxHZFFuHJy4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3kFbv9DtFp4pl518A8Z3dBFfDkF81AWQmr0kgrxJJRwqQ9T4o kQ9b0Q7xmuLZ+QUF8HnmdwVmvBNGsDxJ1MEfzD7SAIEPo3ojeL0Lln01CgRghb3eYuY1ONGEvnf hgwxeF4rPyJnUr8/4s3zYa+P304CbQ7HHXdK27Te5u8qzE7l/wkkQhdwvVQHkzBwUcH4= X-Gm-Gg: Acq92OFu7AEFCDk8UevBk08UvtbzAc3qgzAae0LI4QMmWDN+iuLenpdNZUo2xIta9+w iuUlkSIiqhEjhPPrjFiB6HJUE51D3/XirJGQx/ZLi9jshGhFNBm6Cp0ex3BxbC2vcIqY9zvdQkR vubPtBsCbEgVYqAVAPfWiJQxeRSycMzwcRIx54usl9DiPrB8KNhE6hu6PvhtOt0+B/NHY/uaSs9 KqiP1eGYKRgUtxBQUPL76sUARaSagO94Nd72MCwxEq4MxsUjtg2EUgJJ3p6D47wzCMbv51jQY15 5DMAd+UQ6whS+9+47ndS7s53R7nFtKpHMWmAqMBHIV32ArE60Lu54E1Ku3Kgefvm5C5Ypw0upgK sm9Dy2Sj/Pzl0VltMC1zvV3sRBP8IA9YmS3pPRCadIF6ZicCLQJWTbJhC6z/7Ln3Vygo= X-Received: by 2002:a05:6a00:4006:b0:827:2a07:231d with SMTP id d2e1a72fcca58-8414acdeba9mr2010679b3a.17.1779349214182; Thu, 21 May 2026 00:40:14 -0700 (PDT) X-Received: by 2002:a05:6a00:4006:b0:827:2a07:231d with SMTP id d2e1a72fcca58-8414acdeba9mr2010643b3a.17.1779349213557; Thu, 21 May 2026 00:40:13 -0700 (PDT) Received: from [10.217.219.207] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84154e22f1esm477039b3a.47.2026.05.21.00.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 00:40:13 -0700 (PDT) Message-ID: <4979e748-ce4e-4244-8906-e22a1e6472e7@oss.qualcomm.com> Date: Thu, 21 May 2026 13:10:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] i2c: imx: mark I2C adapter when hardware is powered down To: "Carlos Song (OSS)" , o.rempel@pengutronix.de, kernel@pengutronix.de, andi.shyti@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, festevam@gmail.com, carlos.song@nxp.com, haibo.chen@nxp.com Cc: linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260520101504.2885873-1-carlos.song@oss.nxp.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260520101504.2885873-1-carlos.song@oss.nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: A8KAolQRSX-uZMzUs3Lo1ug3Bz07cKgU X-Authority-Analysis: v=2.4 cv=e5k2j6p/ c=1 sm=1 tr=0 ts=6a0eb6de cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=8AirrxEcAAAA:8 a=VwQbUJbxAAAA:8 a=KOk9-1IoVFRPxriqIuUA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=ST-jHhOKWsTCqRlWije3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA3MyBTYWx0ZWRfX0QJDMedTOFq4 yX4UazTzos2Iip+u9x1nl5ayCBlgwjx3jm4Ej/sbnfkNOmjFRAtRJev7rrxneYSph2fMBHJUmeL IKS6RMej6k8z/ARmeuIoxkXAmQr7WJRFb5XFZPeiS0arH9eh7rokJAGZqVrqcKF1Jl5dXL+mtVZ ej2vi0L7klwlRezSEC/VITXcy0B2nrtH5UNySjmpk70jg5Zl9XWFzSJrbjhH3RvaPAUFxp+KiNK dmJM5y4WGqi9lD2fVN2JY1wN9uFjwMS1Omn3SbaCHlUGPv2CZjVek6+ASDY+4JdORJX0O5YJWoW Rz2xpN5BtMLaGA4sfYMQ9BG1P8Qs3jYdJPFFac55p3UB/sMy3YFfeYmb0Ku88nhXLrMrlPTI5w2 7wijY0sRO4k1X+AGvtY+c5Okr4X7RXmfpw3S3BQTMXT6rpP4kmRQUjzuOQTGP965cYUXvMwvCcE bDZnDMuX8eVmL4yVE+A== X-Proofpoint-GUID: A8KAolQRSX-uZMzUs3Lo1ug3Bz07cKgU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210073 Hi Carlos, On 5/20/2026 3:45 PM, Carlos Song (OSS) wrote: > From: Carlos Song > > Mark the I2C adapter as suspended during system suspend to block further > transfers, and resume it on system resume. This prevents potential hangs > when the hardware is powered down but clients still attempt I2C transfers. > Code changes looks fine to me but have comment on commit log. It seems, you are adding support of _noirq() callbacks to allow transfers during suspend/resume noirq phase of PM. Would it make sense if you can write "Replace system PM callbacks with noirq PM callbacks" OR "Allow transfers during _noirq phase of the PM ops" instead of "mark I2C adapter when hardware is powered down" ? > Fixes: 358025ac091e ("i2c: imx: make controller available until system suspend_noirq() and from resume_noirq()") > Cc: stable@vger.kernel.org > Signed-off-by: Carlos Song > --- > Change for v3: > - Add hrtimer_cancel in i2c_imx_suspend_noirq to cancel slave_timer for > safe suspend in i2c slave mode. > Change for v2: > - Call i2c_mark_adapter_suspended() before pm_runtime_force_suspend() > to prevent potential deadlock if a transfer is active during suspend. > - Roll back with i2c_mark_adapter_resumed() if pm_runtime_force_suspend() > fails. > --- [...]