From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D370D31F9A7 for ; Wed, 11 Mar 2026 08:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773219398; cv=none; b=QmMfsXbzATYhK1YLBzsS1C5Co8mALSiYzjJJIcFUwwpjVEJ7S+hEF6U1GotXgOvGAnBWkhpPlYBp7gLknZLjcLN+vdbw/Zt4jtXHDLWA4Q2k1IYvDsx9J7RwQ6kh4b71WzjEnJYyBSg9uw9JckOi5UvVUgzGBvIYsJy79bxgTz4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773219398; c=relaxed/simple; bh=GxhyEOLS942YERY522cw1a/tosTCri9aYho+t2RDWNM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uekO6es7z3O5t/m6t4F1n5+LgCdrKeb2zAKEer0DwxoWx23tM49q+d4n0GyZWGz8iQpQJPSfI4LcFSEXZHE5716imL07tV8in9MdWu+0Cr5YbLxmmZ9ftX7kPCxSzw5GgeFsabgCzP/H9s0mykKVXEE69eFrKYuRmrxQ994kYc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S0Rl+f+9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q7K4UOqa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S0Rl+f+9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q7K4UOqa" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B6Zmd31439702 for ; Wed, 11 Mar 2026 08:56:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pl93YixHoiXJRlfs0OC+xUhIllfIU75ORxITZTmWc/M=; b=S0Rl+f+9vCPnI9qC eEiaMpLDIEFN8aD6LBP9VEQlHz6L/ndG+TSVH4vBerkVjELtft+mc0evvM4omCsp /61XbzfWagl2khT3UXmTaVSkIyZ/f01Z4HXeKKrx4JikSxeWWwOFnSxcoJZ65XFT 5SEEpMIcbgoim0sQI/ENbVbzWxxIBMz9sgZJa+WnambHBx3XuA44nOgzx/PZ1Arr JRPz/T8/eBP1hwHdgainqlJZORL7OmC1tc6HGSafgV4uxV6VPcdbm5jbTGmetkRA pP4G4lRDQPwjy/PxBBTzk+ESI4OnkmqOwAjvctsoKDrHIUDdiMaHRGL6HkVB+sqO 9b7rOA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu38ygfwy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 08:56:33 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c7387c70046so3297538a12.0 for ; Wed, 11 Mar 2026 01:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773219393; x=1773824193; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pl93YixHoiXJRlfs0OC+xUhIllfIU75ORxITZTmWc/M=; b=Q7K4UOqaYY5lQ3u0i7V0aDfqilXwd5HNDgDXF1oxUG+hBHu9nTIomVp130082uyhRI xgvxBr4ryzHMDWWSZ8gR8LfubQmyyi6GdrvxDzIFHBPJBItceiL4jqy/rzcd5/LT64SD W89Sn4L7/6s0Zany3ZEPWLqwg0E3b3Mb5S03RTC6IcvxZl4bp3odY2/OfCHPHsFhTuyD 4KMG4lr9qaViF1fIz0Sk5cyNduXlrhbOH0VHe/IeR0oPgAqzVu54RGOtubxmSnL5R6w8 N0tHMRuIJz6k/t3yLLb/Ra4uhcUtMo88ZR9EcFWJfW92HcUIQZsc9/jsdQyMVUWQwMW3 CmXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773219393; x=1773824193; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pl93YixHoiXJRlfs0OC+xUhIllfIU75ORxITZTmWc/M=; b=Zz2VTeKqHTlIx7bKkH10PlyjIZQYKuarEaMAIhtKtAqK033HSghkCaH4EmgjA467A8 a/6serwzQd8TfSedEDWV0kRXiqFMd5+xiNaGsBc9kIDin2P+SA8HLGwPNlXC4P5Y1Gcr 6ReDGfqTYC/HDa18E+K+EPVbfW1Ql6wjnRMyqyF+Mr8v8DyACO4vaO8O+Q3Uj2RX9ezl NNABZ0Ag46jX8hSsWySrGxG5BPsSzMaNtTfZwr4N1sRYVenX1u5QNwsQu8Su1B7HhMDq mUotRTQ9E5marXXE8i9FV+nCAlMFjH0e3N4MgsJr0HJmVR9ZkgGDBSOLOpyN85SU047J 9H0Q== X-Forwarded-Encrypted: i=1; AJvYcCXKNfGGWqgbuh9bHt37c25+KeXhl+1XyJbMu+4d2W+hz9sTyHaiJXBB2uWb71BlwNaQ27otDp0H3i+PcVA=@vger.kernel.org X-Gm-Message-State: AOJu0Yykifsg49idEg8e/af6d6A6u9pXJ06C+nYMrqtlZPJg0RNAFuhn mzQuaO2UFexBva1sMrigkub47YS8FosIAa1zS3yUgZ50aBODIdHd37Q73u5WIP3fZunYdlTqzL9 hqKU5GtONImj9RMRK2L/HvrvCoU8r+6W8CCyzbQCrmVp3tUClcmVjUPA2l+CkjEAYxIs= X-Gm-Gg: ATEYQzzNlSL0tzKZvrobq0XZNjCLtI3fILlxp40k7+tPpM54nyStoYHBzibSwNvHr2N dvIjyUMTZJGCu7NewR8chIRzPotJXz+UO75qgFx35r1K4I4uELsj29TOL1DeS0z4/Yx3q10ngIL C6Qz4SkeVu2nMpSontLW96CuJEcJlU7ndSaN3GnFTJRkq1crca/ra9yleQwoNf5vwHt+3egsrnp umu732zMUtzfVgbFPSWTaktkVV4XpKYPr+vpE1FihyeUJOnY3GvBfSC/ajP5ux5FK//yOd1deyh 8qFvvlpXQWgN1pbL9b99C2TY16xPyeNOAwSplNlAtcAU7nEu5a0qGz0R8BiP4M9HmdCzwH1Z3Vr ez9rDxuUcwy3oL8pFUqLcyYsK/hJgfBV4nf+SH/B3yW4cmtiNNT0= X-Received: by 2002:a05:6a21:496:b0:398:71f2:59b7 with SMTP id adf61e73a8af0-398c60e4310mr1515113637.33.1773219392828; Wed, 11 Mar 2026 01:56:32 -0700 (PDT) X-Received: by 2002:a05:6a21:496:b0:398:71f2:59b7 with SMTP id adf61e73a8af0-398c60e4310mr1515088637.33.1773219392343; Wed, 11 Mar 2026 01:56:32 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73cdf2725csm1523345a12.13.2026.03.11.01.56.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 01:56:31 -0700 (PDT) Message-ID: <497b2adb-bcab-4c81-b6d6-56e7102f416c@oss.qualcomm.com> Date: Wed, 11 Mar 2026 14:26:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk To: Konrad Dybcio , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , Yuvaraj Ranganathan , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20260310-qcom_ice_power_and_clk_vote-v2-0-b9c2a5471d9e@oss.qualcomm.com> <20260310-qcom_ice_power_and_clk_vote-v2-1-b9c2a5471d9e@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA3NCBTYWx0ZWRfXzq4tBzFab45t VuNyTrGmYGNY6QeupPlu1XMCfhSFZQnSic+bDIIpgu+IVO+kiSUR1YIxvh3RGEkP7MgUCVE8Lqg rWSeGWwXHEO8KhJmymfnrzKH3srg75MdQW1qxeFYoJ0caoe31ckNTQHMqTLOhnLzEVWb3blqT4j iDHyVeDZVkqY4Nm0L4q04WJvT76PJr1SpaBeIl29mbcPMaxNmc5LIp6MyHWw6nThJzh3f2OoZD2 n/hHcj4wlDyFwy5Jifi8lwbE8vrmtRYQuzOijFO7BiG6li/uOJWKO1tvAu2n0WO6xkxE5KfjqTJ /IZZhGsmPgQdMLnQ/GoVb0+lNE4VJhYGaB4oDiwwiosd7seH15lG1fErYAbc++FMb1fcba9fAdh l9xqLiwuVFHggKAN51pYpY1gwsUXqcixwUhDuh+NqTdcED9n+hMfEbybmLV5yDbEmId+FPTj02b Ua5HEIhrUUmQGgZ4Isw== X-Proofpoint-GUID: IDmi1NnTVunkI5Hmc8Db_fkTiQoKWRC4 X-Proofpoint-ORIG-GUID: IDmi1NnTVunkI5Hmc8Db_fkTiQoKWRC4 X-Authority-Analysis: v=2.4 cv=Cq+ys34D c=1 sm=1 tr=0 ts=69b12e41 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=8h99a6YZr-iq8KHAznkA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110074 On 3/10/2026 7:43 PM, Konrad Dybcio wrote: > On 3/10/26 9:06 AM, Harshal Dev wrote: >> Update the inline-crypto engine DT binding to allow specifying up to two >> clocks along with their names and associated power-domain. When the >> 'clk_ignore_unused' flag is not passed on the kernel command line >> occasional unclocked ICE hardware register access are observed during ICE >> driver probe based on the relative timing between the probe and the kernel >> disabling the unused clocks. On the other hand, when the 'pd_ignore_unused' >> flag is not passed on the command line, clock 'stuck' issues are >> observed if the power-domain required by ICE hardware is unused and thus >> disabled before ICE probe. To avoid these scenarios, the 'iface' clock and >> the associated power-domain should be specified in the ICE device tree node >> and the 'iface' clock should be voted on by the ICE driver during probe. >> >> Fixes: f6ff91a47ac57 ("dt-bindings: crypto: Add Qualcomm Inline Crypto Engine") >> Signed-off-by: Harshal Dev >> --- >> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> index c3408dcf5d20..d9a0a8adf645 100644 >> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >> @@ -28,6 +28,16 @@ properties: >> maxItems: 1 >> >> clocks: >> + minItems: 1 >> + maxItems: 2 >> + >> + clock-names: >> + minItems: 1 >> + items: >> + - const: ice_core_clk >> + - const: iface_clk > > Trim the "_clk", we know they're clocks, because they come under.. you > know.. the 'clocks' property! :D > Ack. Regards, Harshal > Konrad