mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Eric Biggers <ebiggers@kernel.org>,
	x86@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Subject: Re: [PATCH] x86/its: Fix build errors when CONFIG_MODULES=n
Date: Tue, 13 May 2025 13:32:07 -0700	[thread overview]
Message-ID: <49808711-a5af-488a-9fd1-246c4da10100@intel.com> (raw)
In-Reply-To: <688ec9f5-b59a-46c0-97d9-f4d0635fac6e@intel.com>

On 5/13/25 11:54, Dave Hansen wrote:
> On 5/12/25 19:58, Eric Biggers wrote:
>> From: Eric Biggers <ebiggers@google.com>
>>
>> Fix several build errors when CONFIG_MODULES=n, including the following:
>>
>> ../arch/x86/kernel/alternative.c:195:25: error: incomplete definition of type 'struct module'
>>   195 |         for (int i = 0; i < mod->its_num_pages; i++) {

Linus, could you pick this one up directly, please? The thread has acks
from a few folks already.

The normal x86/urgent branch doesn't have this bug yet and I don't want
to merge the existing pile of fixes with your tree at a completely
random point.

Oh, and you called it ... "done without public testing" strikes again.

  reply	other threads:[~2025-05-13 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13  2:58 Eric Biggers
2025-05-13 18:06 ` Alexandre Chartre
2025-05-13 18:15 ` Steven Rostedt
2025-05-13 18:17 ` Steven Rostedt
2025-05-13 19:23   ` Harshit Mogalapalli
2025-05-13 19:30     ` Steven Rostedt
2025-05-13 18:54 ` Dave Hansen
2025-05-13 20:32   ` Dave Hansen [this message]
2025-05-13 21:36     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49808711-a5af-488a-9fd1-246c4da10100@intel.com \
    --to=dave.hansen@intel.com \
    --cc=ebiggers@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®