Re: [PATCH v2 01/11] accel/rocket: search every core slot when a core is removed

["Heiko Stübner" <heiko@sntech.de>]

Am Dienstag, 22. September 2026, 10:01:04 Mitteleuropäische Normalzeit schrieb Igor Paunovic:
> rocket_remove() decrements rdev->num_cores for each core it removes,
> while find_core_for_dev() searches slots 0 to num_cores - 1. Unbinding
> the cores in the order they were bound therefore loses the last one: by
> the time it is removed the search range has already shrunk past its
> slot, so find_core_for_dev() returns -1 and rocket_remove() gives up
> without doing anything.

[...]

> Two paragraphs changed from the standalone posting, which this series
> supersedes: the one on unbinding a single core now points at patch 4
> instead of saying what is left, and the round counts are dropped from
> the last one. Posting:
> https://lore.kernel.org/r/20260904125936.26234-1-royalnet026@gmail.com
> The two Tested-by tags are from that thread. The round counts were
> taken on a kernel that carried the use-after-free fixed in 8/11; they
> were re-measured with the whole series applied, see the notes on patch
> 4 and the cover letter. The single-core unbind and rocket_open() cases
> in that paragraph are 2/2 of the lifecycle series, now rebased into
> this one as patch 4:
> https://lore.kernel.org/r/20260731064933.12548-3-royalnet026@gmail.com

Seems like I merged the standalone version in [0].

The code change is the same, so I guess we'll just have to live with
the older commit description :-) .

TL;DR this has been merged in 7.3 already now.


Heiko


[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6eff1d69dae808a1518aee5a58d0853a8db3f1be