From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754491Ab3AVV7q (ORCPT ); Tue, 22 Jan 2013 16:59:46 -0500 Received: from hydra.sisk.pl ([212.160.235.94]:50675 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752888Ab3AVV7n (ORCPT ); Tue, 22 Jan 2013 16:59:43 -0500 From: "Rafael J. Wysocki" To: Toshi Kani Cc: ACPI Devel Maling List , LKML , Len Brown , Matthew Garrett , Bjorn Helgaas , Yinghai Lu Subject: Re: [PATCH] ACPI: Remove useless type argument of driver .remove() operation Date: Tue, 22 Jan 2013 23:05:45 +0100 Message-ID: <4985933.byC9yivxkj@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.8.0-rc4; KDE/4.9.5; x86_64; ; ) In-Reply-To: <1358889867.14145.354.camel@misato.fc.hp.com> References: <1518653.CUpDmbmCI3@vostro.rjw.lan> <1358889867.14145.354.camel@misato.fc.hp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, January 22, 2013 02:24:27 PM Toshi Kani wrote: > On Sun, 2013-01-20 at 23:04 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The second argument of ACPI driver .remove() operation is only used > > by the ACPI processor driver and the value passed to that driver > > through it is always available from the given struct acpi_device > > object's removal_type field. For this reason, the second ACPI driver > > .remove() argument is in fact useless, so drop it. > > > > Signed-off-by: Rafael J. Wysocki > > Thanks for the clean-up! It looks good. > > Acked-by: Toshi Kani Thanks! Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.