From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lukasz Luba <lukasz.luba@arm.com>
Subject: [PATCH v1 2/3] thermal: gov_bang_bang: Relocate regulation logic description
Date: Thu, 16 Jan 2025 20:31:11 +0100 [thread overview]
Message-ID: <4987649.31r3eYUQgx@rjwysocki.net> (raw)
In-Reply-To: <2772026.mvXUDI8C0e@rjwysocki.net>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Move the regulation logic description from the bang_bang_trip_crossed()
kerneldoc to the preamble.
No functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/thermal/gov_bang_bang.c | 43 +++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 22 deletions(-)
--- a/drivers/thermal/gov_bang_bang.c
+++ b/drivers/thermal/gov_bang_bang.c
@@ -7,6 +7,27 @@
* Based on step_wise.c with following Copyrights:
* Copyright (C) 2012 Intel Corp
* Copyright (C) 2012 Durgadoss R <durgadoss.r@intel.com>
+ *
+ * Regulation Logic: a two point regulation, deliver cooling state depending
+ * on the previous state shown in this diagram:
+ *
+ * Fan: OFF ON
+ *
+ * |
+ * |
+ * trip_temp: +---->+
+ * | | ^
+ * | | |
+ * | | Temperature
+ * (trip_temp - hyst): +<----+
+ * |
+ * |
+ * |
+ *
+ * * If the fan is not running and temperature exceeds trip_temp, the fan
+ * gets turned on.
+ * * In case the fan is running, temperature must fall below
+ * (trip_temp - hyst) so that the fan gets turned off again.
*/
#include <linux/thermal.h>
@@ -38,28 +59,6 @@
* @tz: thermal_zone_device
* @trip: the trip point
* @crossed_up: whether or not the trip has been crossed on the way up
- *
- * Regulation Logic: a two point regulation, deliver cooling state depending
- * on the previous state shown in this diagram:
- *
- * Fan: OFF ON
- *
- * |
- * |
- * trip_temp: +---->+
- * | | ^
- * | | |
- * | | Temperature
- * (trip_temp - hyst): +<----+
- * |
- * |
- * |
- *
- * * If the fan is not running and temperature exceeds trip_temp, the fan
- * gets turned on.
- * * In case the fan is running, temperature must fall below
- * (trip_temp - hyst) so that the fan gets turned off again.
- *
*/
static void bang_bang_trip_crossed(struct thermal_zone_device *tz,
const struct thermal_trip *trip,
next prev parent reply other threads:[~2025-01-16 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 19:29 [PATCH v1 0/3] thermal: core: Cosmetic updates Rafael J. Wysocki
2025-01-16 19:30 ` [PATCH v1 1/3] thermal: core: Rename callback functions in two governors Rafael J. Wysocki
2025-01-17 8:47 ` Lukasz Luba
2025-01-16 19:31 ` Rafael J. Wysocki [this message]
2025-01-17 8:51 ` [PATCH v1 2/3] thermal: gov_bang_bang: Relocate regulation logic description Lukasz Luba
2025-01-16 19:31 ` [PATCH v1 3/3] thermal: core: Rename function argument related to trip crossing Rafael J. Wysocki
2025-01-17 8:52 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4987649.31r3eYUQgx@rjwysocki.net \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®