From: Phillip Lougher <phillip@lougher.demon.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
snakebyte@gmx.de, sliedes@cc.hut.fi
Subject: Re: [PATCH] Squashfs: Fix oops when reading fsfuzzer corrupted filesystems
Date: Fri, 06 Feb 2009 00:58:53 +0000 [thread overview]
Message-ID: <498B8B4D.3070603@lougher.demon.co.uk> (raw)
In-Reply-To: <20090205122215.adcd18db.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Wed, 04 Feb 2009 03:07:48 +0000
> Phillip Lougher <phillip@lougher.demon.co.uk> wrote:
>
>> - ERROR("sb_bread failed reading block 0x%llx\n", cur_index);
>> + ERROR("squashfs_read_data failed to read block 0x%llx\n", index);
>
> `index' has type u64. You don't know what C type is used to implement
> u64, hence it must be cast to a known type before it can be passed to
> printk.
>
Yeah missed that. I resisted using u64 and used 'long long' for these
until very recently.
Phillip
prev parent reply other threads:[~2009-02-06 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-04 3:07 Phillip Lougher
2009-02-05 20:22 ` Andrew Morton
2009-02-06 0:58 ` Phillip Lougher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498B8B4D.3070603@lougher.demon.co.uk \
--to=phillip@lougher.demon.co.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sliedes@cc.hut.fi \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®