From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755302AbcIUHf4 (ORCPT ); Wed, 21 Sep 2016 03:35:56 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:33965 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853AbcIUHfJ (ORCPT ); Wed, 21 Sep 2016 03:35:09 -0400 Subject: Re: [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs To: Vinod Koul References: <20160916083324.29133-1-peter.ujfalusi@ti.com> <20160916083324.29133-6-peter.ujfalusi@ti.com> <20160921035131.GD2609@localhost> <20160921035326.GF2609@localhost> CC: , , , , , , From: Peter Ujfalusi Message-ID: <498a255b-27a7-20fe-9736-ede2b5bdebe6@ti.com> Date: Wed, 21 Sep 2016 10:34:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160921035326.GF2609@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/16 06:53, Vinod Koul wrote: > On Wed, Sep 21, 2016 at 09:21:32AM +0530, Vinod Koul wrote: >> On Fri, Sep 16, 2016 at 11:33:20AM +0300, Peter Ujfalusi wrote: >>> The DMAengine driver for omap-dma use three function calls from the >>> plat-omap legacy driver. When the DMAengine driver is built when ARCH_OMAP >>> is not set, the compilation will fail due to missing symbols. >>> Add empty inline functions to allow the DMAengine driver to be compiled >>> with COMPILE_TEST. >> >> Peter, >> >> This should be before you enable COMPILE_TEST otherwise build will break! > > Ah never mind, you have three drivers in this series so I think this is fine > before the omap one :) Yep, patch 1-4 is for eDMA, patch 5-6 is for omap-dma and the remaining is for ti-dma-crossbar. I wanted to have them separate (including when I enable the COMPILE_TEST) so we can revert easily if needed. If I move the 'enable COMPILE_TEST' patches at the end of the series, I think I will still have them as separate as they are enabling the test for three different driver. -- Péter