mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: lee@kernel.org, pavel@kernel.org
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, i@rong.moe
Subject: Re: [PATCH v3 10/11] leds: rgb: ktd202x: Initialize max_brightness before registering LED
Date: Sat, 21 Nov 2026 13:53:22 +0100	[thread overview]
Message-ID: <498a9e07-3b8e-4dce-86da-37c9eb2837a5@gmx.de> (raw)
In-Reply-To: <20261120212431.152081-11-W_Armin@gmx.de>

Am 20.11.26 um 22:22 schrieb Armin Wolf:

> Initializing max_brightness after having already registered the LED
> class device will overwrite any adjustments made via devicetree and
> mess up the multicolor LED fallback path for multi_intensity_max.
>
> Fix this by initializing max_brightness brefore registering the LED
> class device.

Sashiko now complains that initializing info[i].intensity with KTD202X_MAX_BRIGHTNESS
will cause issues if max_brightness is being lowered by devicetree properties.

AFAIK many RGB LED drivers have this problem, and i am uneasy in making large changes
to them without being able to test them on real hardware.

Do you want me to fix this issue too or do you consider it out-of-scope?

Thanks,
Armin Wolf

> Fixes: 0ebdb7210943 ("leds: Add ktd202x driver")
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
>   drivers/leds/rgb/leds-ktd202x.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/rgb/leds-ktd202x.c b/drivers/leds/rgb/leds-ktd202x.c
> index 143020945e23..2f5d0694c9c9 100644
> --- a/drivers/leds/rgb/leds-ktd202x.c
> +++ b/drivers/leds/rgb/leds-ktd202x.c
> @@ -477,9 +477,11 @@ static int ktd202x_add_led(struct ktd202x *chip, struct fwnode_handle *fwnode, u
>   
>   	if (color == LED_COLOR_ID_RGB) {
>   		cdev = &led->mcdev.led_cdev;
> +		cdev->max_brightness = KTD202X_MAX_BRIGHTNESS;
>   		ret = ktd202x_setup_led_rgb(chip, fwnode, led, &init_data);
>   	} else {
>   		cdev = &led->cdev;
> +		cdev->max_brightness = KTD202X_MAX_BRIGHTNESS;
>   		ret = ktd202x_setup_led_single(chip, fwnode, led, &init_data);
>   	}
>   
> @@ -488,8 +490,6 @@ static int ktd202x_add_led(struct ktd202x *chip, struct fwnode_handle *fwnode, u
>   		return ret;
>   	}
>   
> -	cdev->max_brightness = KTD202X_MAX_BRIGHTNESS;
> -
>   	return 0;
>   }
>   

  reply	other threads:[~2026-11-21 12:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 21:22 [PATCH v3 00/11] leds: class: Support custom sysfs groups on multicolor and flash LEDs Armin Wolf
2026-11-20 21:22 ` [PATCH v3 01/11] leds: class: Constify sysfs attributes Armin Wolf
2026-11-20 21:22 ` [PATCH v3 02/11] leds: multicolor: " Armin Wolf
2026-11-20 21:22 ` [PATCH v3 03/11] leds: flash: " Armin Wolf
2026-11-20 21:22 ` [PATCH v3 04/11] leds: class: Create "brightness_hw_changed" attribute atomically Armin Wolf
2026-11-20 21:22 ` [PATCH v3 05/11] leds: class: Fix race condition when creating the device Armin Wolf
2026-11-20 21:22 ` [PATCH v3 06/11] leds: class: Access brightness_hw_changed exactly once Armin Wolf
2026-11-20 21:22 ` [PATCH v3 07/11] leds: class: Use correct type for brightness_hw_changed field Armin Wolf
2026-11-20 21:22 ` [PATCH v3 08/11] leds: class: Split led_classdev_register_ext() Armin Wolf
2026-11-20 21:22 ` [PATCH v3 09/11] leds: Support custom sysfs groups on multicolor and flash LEDs Armin Wolf
2026-11-20 21:22 ` [PATCH v3 10/11] leds: rgb: ktd202x: Initialize max_brightness before registering LED Armin Wolf
2026-11-21 12:53   ` Armin Wolf [this message]
2026-11-20 21:22 ` [PATCH v3 11/11] leds: multicolor: Adjust maximum subled intensity during initialization Armin Wolf
2026-11-21 11:21 ` [PATCH v3 00/11] leds: class: Support custom sysfs groups on multicolor and flash LEDs Rong Zhang
2026-11-21 12:42   ` Armin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=498a9e07-3b8e-4dce-86da-37c9eb2837a5@gmx.de \
    --to=w_armin@gmx.de \
    --cc=i@rong.moe \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®