From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753502AbdFMQNX (ORCPT ); Tue, 13 Jun 2017 12:13:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:37987 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750899AbdFMQNW (ORCPT ); Tue, 13 Jun 2017 12:13:22 -0400 Subject: Re: [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, x86@kernel.org, boris.ostrovsky@oracle.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, tony.luck@intel.com, bp@alien8.de References: <20170613134507.16983-1-jgross@suse.com> <20170613152014.tax42aevmsfdopxa@gmail.com> From: Juergen Gross Message-ID: <498f5ad7-c203-9b21-c153-e3496755b88d@suse.com> Date: Tue, 13 Jun 2017 18:13:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170613152014.tax42aevmsfdopxa@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/17 17:20, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> When running under Xen as dom0 /dev/mcelog is being registered by Xen >> instead of the normal mcelog driver. Avoid an error message being >> issued by the mcelog driver in this case. Instead issue an informative >> message that Xen has registered the device. >> >> Signed-off-by: Juergen Gross >> --- >> arch/x86/kernel/cpu/mcheck/dev-mcelog.c | 11 +++++++++-- >> drivers/xen/mcelog.c | 2 ++ >> 2 files changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/mcheck/dev-mcelog.c b/arch/x86/kernel/cpu/mcheck/dev-mcelog.c >> index 9c632cb88546..4eb5f7d1d593 100644 >> --- a/arch/x86/kernel/cpu/mcheck/dev-mcelog.c >> +++ b/arch/x86/kernel/cpu/mcheck/dev-mcelog.c >> @@ -388,9 +388,16 @@ static __init int dev_mcelog_init_device(void) >> /* register character device /dev/mcelog */ >> err = misc_register(&mce_chrdev_device); >> if (err) { >> - pr_err("Unable to init device /dev/mcelog (rc: %d)\n", err); >> - return err; >> + if (err == -EBUSY) >> + /* Xen dom0 might have registered the device already. */ >> + pr_info("Unable to init device /dev/mcelog, already registered"); >> + else { >> + pr_err("Unable to init device /dev/mcelog (rc: %d)\n", >> + err); >> + return err; >> + } > > Please only use balanced curly braces in conditional statements. Okay, will change. Juergen