From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755085AbZBKOP6 (ORCPT ); Wed, 11 Feb 2009 09:15:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756622AbZBKOPo (ORCPT ); Wed, 11 Feb 2009 09:15:44 -0500 Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:38318 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbZBKOPn (ORCPT ); Wed, 11 Feb 2009 09:15:43 -0500 Message-ID: <4992DD86.1030607@s5r6.in-berlin.de> Date: Wed, 11 Feb 2009 15:15:34 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.19) Gecko/20081204 SeaMonkey/1.1.14 MIME-Version: 1.0 To: Hannes Hering CC: jeff@garzik.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, netdev@vger.kernel.org, ossrosch@linux.vnet.ibm.com, ossthema@de.ibm.com, raisch@de.ibm.com, themann@de.ibm.com, osstklei@de.ibm.com Subject: Re: [PATCH] ehea: Fix: Remove adapter from adapter list in error path References: <200902111329.02954.hannes.hering@linux.vnet.ibm.com> In-Reply-To: <200902111329.02954.hannes.hering@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hannes Hering wrote: > Remove adapter from adapter list before freeing data structure in error path. ... > --- linux-2.6.29-rc4/drivers/net/ehea/ehea_main.c 2009-02-11 13:13:47.812542928 +0100 > +++ patched_kernel/drivers/net/ehea/ehea_main.c 2009-02-11 13:14:04.197540184 +0100 > @@ -3448,6 +3448,7 @@ out_kill_eq: > ehea_destroy_eq(adapter->neq); > > out_free_ad: > + list_del(&adapter->list); > kfree(adapter); > > out: On a related note, ehea_set_mac_addr()/ehea_update_bcmc_registrations() accesses adapter_list without serialization by ehea_fw_handles.lock and thus apparently unsafely. There may be other unsafe accesses of adapter_list; that's just the first one which I spotted. -- Stefan Richter -=====-==--= --=- -=-== http://arcgraph.de/sr/