From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbdJLQGz (ORCPT ); Thu, 12 Oct 2017 12:06:55 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:24858 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbdJLQGw (ORCPT ); Thu, 12 Oct 2017 12:06:52 -0400 X-AuditID: b6c32a45-d23ff70000001088-29-59df93191a5a From: Bartlomiej Zolnierkiewicz To: Bhumika Goyal Cc: julia.lawall@lip6.fr, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sparclinux@vger.kernel.org Subject: Re: [PATCH] video: fbdev: make fb_var_screeninfo static, const and __initconst Date: Thu, 12 Oct 2017 18:06:46 +0200 Message-id: <4996127.oJ8tDUhiv1@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1505392334-8001-1-git-send-email-bhumirks@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRmVeSWpSXmKPExsWy7bCmqa7k5PuRBpvniFp8utfPZnHl63s2 i2UPTjNanOj7wGpxedccNouGkytYHdg8ds66y+6xd0uWx/3u40wenzfJBbBEcdmkpOZklqUW 6dslcGWcm/uKseA+R0Xn3h/sDYz/2LoYOTkkBEwk7vZ8YQaxhQR2MEp82OPexcgFZH9nlHh/ ZwYjTFH77R3sEIkNjBJfus+wQjhfGSXenr8GVsUmYCUxsX0VmC0ioCZxo2sl2FhmgSmMEvdv 54LYwgKREsvbbjB1MXJwsAioSrz4wg0S5hXQlLjxfRtYq6iAl8SWfe1MIDangJPEt5sQY3gF BCV+TL7HAjFSXmLf/qmsELaOxNlj6xhB7pEQ2MAmsfDvPXaIq10kFvy/CGULS7w6vgXKlpZ4 tmoj1GfTGSW2/5aAaN7MKLFq9wSoImuJw8cvQm3gk+g4/Jcd5GgJAV6JjjYhiBIPic1Tl7BA 2I4SrzceY4IEylRGifmXV7NOYJSdheTwWUgOn4Xk8AWMzKsYxVILinPTU4uNCgz1ihNzi0vz 0vWS83M3MYLTgZbrDsYZ53wOMQpwMCrx8O4ovx8pxJpYVlyZe4hRgoNZSYTXoxMoxJuSWFmV WpQfX1Sak1p8iFGag0VJnLd+27UIIYH0xJLU7NTUgtQimCwTB6dUA+O+/53a83/8Eki6u37N /LYZVQ/Dmh0Vhb557Yr+a1XZdtntwtwFuhdPBf0pr244tin9id4b4b4jp1ySX023ujZRtf1F f93/ejURvbvaModPFl0Iranq1nupyDn52Izi/1fPHJz+XUqzc2HTd57vGtvib4Z6Tnx0aIfc XDWWh33X0kN06vRnlukrsRRnJBpqMRcVJwIACW/rDgMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t9jQV2JyfcjDbZ8t7D4dK+fzeLK1/ds FssenGa0ONH3gdXi8q45bBYNJ1ewOrB57Jx1l91j75Ysj/vdx5k8Pm+SC2CJ4rJJSc3JLEst 0rdL4Mo4N/cVY8F9jorOvT/YGxj/sXUxcnJICJhItN/ewd7FyMUhJLCOUeJD80FmCOcro0TL iz9MIFVsAlYSE9tXMYLYIgJqEje6VoIVMQtMYZR4/fk1WEJYIFLicvs2oFEcHCwCqhIvvnCD hHkFNCVufN8GViIq4CWxZV872ExOASeJbzdB5nACLZvOKPH/dzZEvaDEj8n3WEBsZgF5iX37 p7JC2FoS63ceZ5rAyD8LSdksJGWzkJQtYGRexSiZWlCcm55bbFRglJdarlecmFtcmpeul5yf u4kRGMDbDmv172B8vCT+EKMAB6MSD++O8vuRQqyJZcWVuYcYJTiYlUR4PTqBQrwpiZVVqUX5 8UWlOanFhxilOViUxHn5849FCgmkJ5akZqemFqQWwWSZODilGhgjlzBUicleUHiS/cGqorTa tn7F+jd69w+rFMYybVer4qx+8XdP48J2N2sJjuyTrZP3tHD+VjR4UnPs7Kbe+vsH57/+0SN2 Z46o8LS6lw8PHRQvXuW9Y/OS5kcfOnMV9Py/tOs9ORtrqc5b+SiTq3HFRu4fPEqnOm8euHj3 6R5nq1DtjFN3Li1QYinOSDTUYi4qTgQAIpuCOFwCAAA= X-CMS-MailID: 20171012160649epcas2p443ccdf3e036177bb085ed6ea59d6c3d9 X-Msg-Generator: CA X-Sender-IP: 182.195.42.143 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 102P X-CMS-RootMailID: 20170914123228epcas3p4350c227f0fc18cd8d36bd92c1e93eff8 X-RootMTR: 20170914123228epcas3p4350c227f0fc18cd8d36bd92c1e93eff8 References: <1505392334-8001-1-git-send-email-bhumirks@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ added dri-devel & sparclinux MLs to cc: ] On Thursday, September 14, 2017 06:02:14 PM Bhumika Goyal wrote: > Make these structures static as they are not referenced in any other > file. Make them const as they are used only during a copy operation. > Replace __initdata with __initconst in file igafb.c to avoid section > conflict error. > > Signed-off-by: Bhumika Goyal > --- > The changes are not compile tested as I could not find the right > architecture to cross compile the files. > > drivers/video/fbdev/dnfb.c | 2 +- > drivers/video/fbdev/igafb.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) You can deduce such things by looking into Makefile-s and KConfig-s: - dnfb is used by apollo platform of m68k arch - igafb can be used on sparc32 arch I took care of compile testing these changes and discovered that in the current vanilla kernel (v4.14-rc4) igafb fails to build. Thus I've only queued dnfb changes for v4.15 kernel for now. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics