From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7123244B681 for ; Wed, 21 Jan 2026 16:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769013165; cv=none; b=DFp3uZKDCV3dVV9JAGQihWoDZ7LIDD+LzyhEMmIFH8W5fvP/kZR+vBfFWKb2b9JjR1OEhzuNts/xs/+VIR+EKQ1EBCiBPCgwkT/DIEfeI1VV6ZWhXMBsvBXlGo3Ho8Zwg0PnbFdr0Urv4k0QVbo3NAIZFjBUR5LQLemhfpFMwCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769013165; c=relaxed/simple; bh=FoyiK1L3Q2N5n/FjMNfanm0zKz84UsrOOXkZRg0Kqz0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LYwCkayqpVqE5u7ppXnRIgt4iG5MildYOgeZJVX4b8eMAvkl8v5+Gfp3IA1w/h+R7XoFr3Lgj1Oc7WmzrX+zOiYBAcjIcMgTlavjYpVEe7PbGVBreky5I4UsKiqyf6HZ/ItcsEKKQH2BKOpWY2rxaes+4QR8+niEv46XwRz6ovU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YfOxEdLr; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=N9iHLl4W; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YfOxEdLr"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="N9iHLl4W" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769013161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nW2BnBCkF2OGoFoub+qogRSB+R7/eG5W/AiAxbiNHik=; b=YfOxEdLrzGHpTeog8pXvSFEY2dGp5/5QO+o3lIshkGSWsop7XUoceIq79xPp9WlbiLYm5T j+8oKKKVJfDgfXKLB53ompC92xLOgf8c1dXDjbohxSnqzr17Ik273EuHg53wj3KJ0PmNlA dLdWZtqRGTPVMExacqO0BTfSvVZA5IM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-a-0aX5ReN6eBYQjbmP-0wg-1; Wed, 21 Jan 2026 11:32:39 -0500 X-MC-Unique: a-0aX5ReN6eBYQjbmP-0wg-1 X-Mimecast-MFC-AGG-ID: a-0aX5ReN6eBYQjbmP-0wg_1769013159 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430fcb6b2ebso904f8f.2 for ; Wed, 21 Jan 2026 08:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769013159; x=1769617959; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nW2BnBCkF2OGoFoub+qogRSB+R7/eG5W/AiAxbiNHik=; b=N9iHLl4W1xkkE58m0BDTVbCkUOBxDa7Ewy5ROgF6r69TQEWlr/1O3JnFPMVbANGp/H EynY5xpxNlzuPGuKsVA4+jEe2+XTmDBQLpRTmwOIeydADuyRstdHWKCrmWO8rG4GOJvM CHzkbHJ6QsA55FrUV7hmMw/waXhijwnKzR4gyjnS5BdjE1qk/59hjCVygxdSV8dauyT7 r8wnc1Qcb8hyGIBkskZfhj2i+26vdwvEbCi0F7NDeU4vKSAnQJ6qKTwXfploOmeNqViG xsybgtZ4vWya1XOisrwKk1EIYJzRKVmF6Nu7uDDVrtUdDuEInsSCOsn5vI1ROUrjR0b7 WKDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769013159; x=1769617959; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nW2BnBCkF2OGoFoub+qogRSB+R7/eG5W/AiAxbiNHik=; b=uUiW+my7iauV/np5t146mTQUM3TaV40MMklM2fBWhzLw3O3DtT4MCf/Q5jG6+h55yX q11apqJWxhzEbNQAm/B8G3KeSVPLX/ByCveJfQPB1/we/jsrCMIlMh9gdhp/wW6BTj99 MUlvL7tmky/1SixbTTPw39X5wP3HXmNTluDKmWh2pNDcKAF1absuk+nFo7qIn5HKSYL9 HyKumwgmmPndaLNF/hTId7pWzI/3mYVpEnous4qlbf0tRfJlUGjxjN9SozheqSBoRYRB mlptyD4u/zsKyaJvCgipxnjIJbKP6E+G44JqhYrDp0XjwBSXZzEDbqqy5CEZDYxwULG5 0mlg== X-Forwarded-Encrypted: i=1; AJvYcCXOdvT8ympnZ9PzUp6UNzvqq4QhTrd30kac38iIDuS+Sk7jTIFpT26M8ayhEwFUpq4SrTvAs+ZKkbsp2+M=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsu+J/4wgJsGH/q8WLntq0Z0rKdjCgzjFMeC/1FVSN96HiMcl8 X4s2s7zZR8Apxt4znx/iwA8LohlrbBcwhYa3/fw7q7Y4C0Ws90/77J0HSd9ZrkPYT7WEDL7bh06 ar2d9FPq0vY6PohmO7EbOW9BGVj6Da+SCTNwGGR8/YEEcNPPv+VX3hBNBD9JArRARhw== X-Gm-Gg: AZuq6aLlqtZWvG9Twr64Ed19gy80khvq81hzCUeKxkwHununmAPtvYB0n1us/KR/E9J /kbjJyIPLjWrBwzdkRdvPCowKFm+P6O1W6J4iVYp+xw6HZVYduyAQVhKyJ3Se0RS/JdIJZ4tuFj i6aScnEcEhQLO+TA4NLkHtsWyuNM1XsDVxXcEoppHlxSKgXBJYStb45cvC5Gp6ataOAyjZxX3sQ K1YSv7ME8hRbiLNGGBxxWQv/pUz3IgmQZyLF+Wi8FijrbFwNAM0JwQCFc4xkt16oW17s/L799H1 sx12xbzC+qE7ZCWjnCW+sp4OJlpODOjfGO4M/3q6CmenI45nvJ0uGUSRzSagxkOYQ00EQfFm2Bt X1Rl1QA/6uZCH X-Received: by 2002:a05:6000:2082:b0:435:693e:c03e with SMTP id ffacd0b85a97d-4356998afa2mr25422057f8f.19.1769013158409; Wed, 21 Jan 2026 08:32:38 -0800 (PST) X-Received: by 2002:a05:6000:2082:b0:435:693e:c03e with SMTP id ffacd0b85a97d-4356998afa2mr25421964f8f.19.1769013157874; Wed, 21 Jan 2026 08:32:37 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.175]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cf58sm38575864f8f.22.2026.01.21.08.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 08:32:36 -0800 (PST) Message-ID: <4997118e-471c-45fe-bc1f-8f6140199db5@redhat.com> Date: Wed, 21 Jan 2026 17:32:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v15 01/12] vsock: add netns to vsock core To: Stefano Garzarella , Bobby Eshleman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , Long Li , Jonathan Corbet , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , linux-doc@vger.kernel.org, Bobby Eshleman References: <20260116-vsock-vmtest-v15-0-bbfd1a668548@meta.com> <20260116-vsock-vmtest-v15-1-bbfd1a668548@meta.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/21/26 3:48 PM, Stefano Garzarella wrote: >> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt >> index a8d0afde7f85..b6e3bfe365a1 100644 >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -8253,6 +8253,20 @@ Kernel parameters >> them quite hard to use for exploits but >> might break your system. >> >> + vsock_init_ns_mode= >> + [KNL,NET] Set the vsock namespace mode for the init >> + (root) network namespace. >> + >> + global [default] The init namespace operates in >> + global mode where CIDs are system-wide and >> + sockets can communicate across global >> + namespaces. >> + >> + local The init namespace operates in local mode >> + where CIDs are private to the namespace and >> + sockets can only communicate within the same >> + namespace. >> + > > My comment on v14 was more to start a discussion :-) sorry to not be > clear. > > I briefly discussed it with Paolo in chat to better understand our > policy between cmdline parameters and module parameters, and it seems > that both are discouraged. Double checking the git log it looks like __setup() usage is less constrained/restricted than what I thought. > So he asked me if we have a use case for this, and thinking about it, I > don't have one at the moment. Also, if a user decides to set all netns > to local, whether init_net is local or global doesn't really matter, > right? > > So perhaps before adding this, we should have a real use case. > Perhaps more than this feature, I would add a way to change the default > of all netns (including init_net) from global to local. But we can do > that later, since all netns have a way to understand what mode they are > in, so we don't break anything and the user has to explicitly change it, > knowing that they are breaking compatibility with pre-netns support.\ Lacking a clear use-case for vsock_init_ns_mode I tend to think it would be better to postpone its introduction. It should be easier to add it later than vice-versa. If there is a clear/well defined/known use-case, I guess the series can go as-is. /P