mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Lyude Paul <lyude@redhat.com>, Danilo Krummrich <dakr@kernel.org>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Edwin Peer" <epeer@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] gpu: nova-core: add FbRange.len() and use it in boot.rs
Date: Wed, 26 Nov 2025 16:53:38 -0800	[thread overview]
Message-ID: <49997040-a745-44aa-94d5-517845271094@nvidia.com> (raw)
In-Reply-To: <44b56a133d2bcbb7606d31839bac1ecfab509ae1.camel@redhat.com>

On 11/26/25 3:43 PM, Lyude Paul wrote:
> I'm not sure this is necessary - for one, we could just use the .len() method
> on the Range. As well - if we just implement Deref for FbRange (which I think
> would be fine here) we could just use .len() through that.

Hi Lyude!

Good idea about the deref coercion. It has a minor type mismatch as-is,
though: Range<u64>::len() returns usize, but FbRange::len() returns u64,
which matches the callers that we have so far.

Thoughts?


thanks,
-- 
John Hubbard

> 
> On Tue, 2025-11-25 at 17:39 -0800, John Hubbard wrote:
>> A tiny simplification: now that FbLayout uses its own specific FbRange
>> type, add an FbRange.len() method, and use that to (very slightly)
>> simplify the calculation of Frts::frts_size initialization.
>>
>> Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>>  drivers/gpu/nova-core/fb.rs       | 6 ++++++
>>  drivers/gpu/nova-core/gsp/boot.rs | 2 +-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs
>> index 333e952400e6..9fcd915e12e1 100644
>> --- a/drivers/gpu/nova-core/fb.rs
>> +++ b/drivers/gpu/nova-core/fb.rs
>> @@ -100,6 +100,12 @@ pub(crate) fn unregister(&self, bar: &Bar0) {
>>  
>>  pub(crate) struct FbRange(Range<u64>);
>>  
>> +impl FbRange {
>> +    pub(crate) fn len(&self) -> u64 {
>> +        self.0.end - self.0.start
>> +    }
>> +}
>> +
>>  impl From<Range<u64>> for FbRange {
>>      fn from(range: Range<u64>) -> Self {
>>          Self(range)
>> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
>> index 54937606b5b0..846064221931 100644
>> --- a/drivers/gpu/nova-core/gsp/boot.rs
>> +++ b/drivers/gpu/nova-core/gsp/boot.rs
>> @@ -70,7 +70,7 @@ fn run_fwsec_frts(
>>              bios,
>>              FwsecCommand::Frts {
>>                  frts_addr: fb_layout.frts.start,
>> -                frts_size: fb_layout.frts.end - fb_layout.frts.start,
>> +                frts_size: fb_layout.frts.len(),
>>              },
>>          )?;
>>  
> 



  reply	other threads:[~2025-11-27  0:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-26  1:39 [PATCH v2 0/5] gpu: nova-core: Hopper/Blackwell prerequisites John Hubbard
2025-11-26  1:39 ` [PATCH v2 1/5] gpu: nova-core: print FB sizes, along with ranges John Hubbard
2025-11-26  1:39 ` [PATCH v2 2/5] gpu: nova-core: add FbRange.len() and use it in boot.rs John Hubbard
2025-11-26 23:43   ` Lyude Paul
2025-11-27  0:53     ` John Hubbard [this message]
2025-11-28  5:27       ` Alexandre Courbot
2025-12-02 17:55         ` Lyude Paul
2025-11-26  1:39 ` [PATCH v2 3/5] gpu: nova-core: Hopper/Blackwell: basic GPU identification John Hubbard
2025-11-26  1:39 ` [PATCH v2 4/5] nova-core: factor .fwsignature* selection into a new get_gsp_sigs_section() John Hubbard
2025-11-26  1:39 ` [PATCH v2 5/5] gpu: nova-core: use GPU Architecture to simplify HAL selections John Hubbard
2025-12-03  5:26 ` [PATCH v2 0/5] gpu: nova-core: Hopper/Blackwell prerequisites John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49997040-a745-44aa-94d5-517845271094@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®