From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbZBPPed (ORCPT ); Mon, 16 Feb 2009 10:34:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750937AbZBPPeY (ORCPT ); Mon, 16 Feb 2009 10:34:24 -0500 Received: from hp3.statik.tu-cottbus.de ([141.43.120.68]:56543 "EHLO hp3.statik.tu-cottbus.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbZBPPeY (ORCPT ); Mon, 16 Feb 2009 10:34:24 -0500 Message-ID: <49998788.80606@s5r6.in-berlin.de> Date: Mon, 16 Feb 2009 16:34:32 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.19) Gecko/20090104 SeaMonkey/1.1.14 MIME-Version: 1.0 To: Manish Katiyar CC: mingo@elte.hu, LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Remove errors caught by checkpatch.pl in kernel/utsname_sysctl.c References: <49996588.2040501@s5r6.in-berlin.de> In-Reply-To: X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Manish Katiyar wrote: > On Mon, Feb 16, 2009 at 6:39 PM, Stefan Richter > wrote: >> The changelog should note that this is a whitespace fix + initcall >> annotation change. Sorry, I didn't get the point of __initcall/device_initcall. It's not an annotation; it defines a call sequence level. > Replace deprecated __initcall with equivalent device_initcall. Also > fix whitespaces. ... > --- a/kernel/utsname_sysctl.c > +++ b/kernel/utsname_sysctl.c ... > @@ -142,4 +142,4 @@ static int __init utsname_sysctl_init(void) > return 0; > } > > -__initcall(utsname_sysctl_init); > +device_initcall(utsname_sysctl_init); It is equivalent, but is it also the most appropriate one? -- Stefan Richter -=====-=-=== -=-= -==-= http://arcgraph.de/sr/