From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Ingo Molnar <mingo@elte.hu>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/main.c: fix sparse warnings: context imbalance
Date: Sun, 22 Feb 2009 13:45:43 +0100 [thread overview]
Message-ID: <49A148F7.1010302@s5r6.in-berlin.de> (raw)
In-Reply-To: <49A1477B.7080206@s5r6.in-berlin.de>
Stefan Richter wrote:
> Hannes Eder wrote:
>> On Sun, Feb 22, 2009 at 12:30 PM, Stefan Richter
>> <stefanr@s5r6.in-berlin.de> wrote:
>>> It is not a fix, it's merely an annotation.
>> This patch 'better word for fix's a warning reported by sparse. What
>> better wording would you suggest?
>
> "annotate init_post() as releasing the BKL" or whatever in the title,
> furthermore "Removes the following sparse warnings: ..." in the changelog.
PS: In some sense it is indeed a "fix" for the high-level problem that
sparse can't guess whether the context imbalance is correct or not. The
original warning from sparse was correct in itself. Your annotation
enables sparse to warn if problems outside the scope of the single
function occur (I guess). So it's more a maintainabiliy improvement
than a fix.
--
Stefan Richter
-=====-==--= --=- =-==-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-02-22 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 19:50 Hannes Eder
2009-02-22 11:30 ` Stefan Richter
2009-02-22 11:36 ` Hannes Eder
2009-02-22 12:39 ` Stefan Richter
2009-02-22 12:45 ` Stefan Richter [this message]
2009-02-24 12:32 ` [PATCH v2] init/main.c: annotate 'init_post' with '__releases(kernel_lock)' Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A148F7.1010302@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=hannes@hanneseder.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®