mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Guennadi Liakhovetski <lg@denx.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	"Sosnowski, Maciej" <maciej.sosnowski@intel.com>
Subject: Re: [PATCH] dmaengine: fix regression introduced by d6103085dfd83c13db65c3bd7e182f021d77c541
Date: Tue, 31 Mar 2009 09:33:46 -0700	[thread overview]
Message-ID: <49D245EA.80704@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0903311755540.4806@axis700.grange>

Guennadi Liakhovetski wrote:
> chan is an index variable, used to loop over a list of channels, and here 
> it is used _after_ the loop, in which case it doesn't point to a DMA 
> channel struct anymore. Dereferencing it leads to a corruption of a random 
> memory location, which in my case was a pointer inside a clock struct. Fix 
> it by using a local variable pointing to the DMA device.
> 
> Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
> ---
> 
> Guys, this was a _real_ bad joke, cost me almost a day, and that patch has 
> been reviewed by two persons...
> 
> <rant>
> So far 2.6.29(-next) has been very bad for me, regressions all over the 
> place, lots of wasted time hunting them down:-(
> </rant>
> 

Guennadi,

Thanks for testing the 'next' branch and finding this before it hit 
mainline.  I will fold this change into the existing commit with a 
[lg@denx.de: fix bad usage of 'chan' in dma_async_device_register]

Regards,
Dan

  reply	other threads:[~2009-03-31 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 16:07 Guennadi Liakhovetski
2009-03-31 16:33 ` Dan Williams [this message]
2009-04-01  1:21 ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49D245EA.80704@intel.com \
    --to=dan.j.williams@intel.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=lg@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.sosnowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®