mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Tomasz Figa <tfiga@chromium.org>,
	kernel@collabora.com, Jonas Karlman <jonas@kwiboo.se>,
	Heiko Stuebner <heiko@sntech.de>,
	Alexandre Courbot <acourbot@chromium.org>,
	Jeffrey Kardatzke <jkardatzke@chromium.org>,
	gustavo.padovan@collabora.com,
	Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [PATCH v3 2/3] media: uapi: Add VP9 stateless decoder controls
Date: Mon, 11 May 2020 08:17:06 -0400	[thread overview]
Message-ID: <49a15300a5db8b4c61115c4a89eac1762dc3f31a.camel@collabora.com> (raw)
In-Reply-To: <7846cb19-c5e0-4f95-c361-cf78d2c1b16a@xs4all.nl>

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

Le vendredi 08 mai 2020 à 15:16 +0200, Hans Verkuil a écrit :
> > I think this comes directly from the spec. The Rockchip VDEC doesn't
> > seem to use it.
> > Do you think we can drop it from here, and rely on the V4L2 colorspace
> > passed in the format negotiation?
> 
> 
> That would be preferred, yes. Otherwise you would have two places where you can
> define colorspaces, and that's confusing.

This is indeed redundant with the color information in the format. In
VP8/9 there is only 1 header for everything, so it's harder to figure-
out what to filter. While in H.264/HEVC this information is usually set
an an extension header.

Though this do re-open the discussion about SPS in H.264/HEVC. In there
you will find the coded size and the crop window and the sub-sampling.
I don't remember exactly what was the conclusion, but I think it was
kept to allow allow bitstream reconstruction. But it will effectively
overlap directly (or indirectly) with some V4L2 generic API.

regards,
Nicolas

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2020-05-11 12:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 13:41 [PATCH v3 0/3] media: rkvdec: Add a VP9 backend Ezequiel Garcia
2020-05-05 13:41 ` [PATCH v3 1/3] media: rkvdec: Fix .buf_prepare Ezequiel Garcia
2020-05-05 13:56   ` Tomasz Figa
2020-05-05 13:59     ` Ezequiel Garcia
2020-05-05 14:05       ` Tomasz Figa
2020-05-05 14:27         ` Ezequiel Garcia
2020-05-13 23:38           ` Nicolas Dufresne
2020-05-14 14:50   ` Nicolas Dufresne
2020-05-05 13:41 ` [PATCH v3 2/3] media: uapi: Add VP9 stateless decoder controls Ezequiel Garcia
2020-05-08 10:27   ` Hans Verkuil
2020-05-08 12:28     ` Ezequiel Garcia
2020-05-08 13:16       ` Hans Verkuil
2020-05-11 12:17         ` Nicolas Dufresne [this message]
2020-05-05 13:41 ` [PATCH v3 3/3] media: rkvdec: Add the VP9 backend Ezequiel Garcia
2020-05-08 10:34   ` Hans Verkuil
2020-05-08 16:26     ` Ezequiel Garcia
2020-05-08 16:56       ` Tomasz Figa
2020-05-11 13:26         ` Ezequiel Garcia
2020-05-08 11:21   ` Jonas Karlman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49a15300a5db8b4c61115c4a89eac1762dc3f31a.camel@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=acourbot@chromium.org \
    --cc=boris.brezillon@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=gustavo.padovan@collabora.com \
    --cc=heiko@sntech.de \
    --cc=hverkuil@xs4all.nl \
    --cc=jkardatzke@chromium.org \
    --cc=jonas@kwiboo.se \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®