From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADE3C43334 for ; Sun, 3 Jul 2022 04:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbiGCEfX (ORCPT ); Sun, 3 Jul 2022 00:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiGCEfV (ORCPT ); Sun, 3 Jul 2022 00:35:21 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C3B65F5 for ; Sat, 2 Jul 2022 21:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656822921; x=1688358921; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=pU3gfZt21o7N90tOYZMfEo8wFf2wBbFCrf4XK6NkYGQ=; b=i0J6GW837YWpP1uSfhzYKdiTv5NMrelxhzfhho5XfUT2YFzQ2XS5jv4z Aoo+iYRjvGTkVSsRiYzL/PtJ8TWqhZXIh8IVelF4zoAhBxkjn3XzDOJH6 ZtdGVMVNQLnDsjbFwL6DGPlyKVeNhDRf7Uz0EofKgxuDx3fVTkk+HsNTC pN/RXex4UY0QRwo8qU7h0b9SSV4mQ34WlE+67ZxtJ6L9E/WchvWqbSLjK loGgAZTNnJ6qJxpJCI6XSfLtRTAZgLbBD5Ao6kMv8OqxmHrZXiaHYTJrd L/Isx3SUW0QE2yw9EBvjvxWQR240WtBvWJ0iSwAM5cUvS0vWIbD4ofcbG Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10396"; a="283631377" X-IronPort-AV: E=Sophos;i="5.92,241,1650956400"; d="scan'208";a="283631377" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 21:35:20 -0700 X-IronPort-AV: E=Sophos;i="5.92,241,1650956400"; d="scan'208";a="648966391" Received: from sunqi-mobl1.ccr.corp.intel.com (HELO [10.249.173.69]) ([10.249.173.69]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 21:35:18 -0700 Message-ID: <49a1839a-c99d-258a-8f85-5a291c646038@linux.intel.com> Date: Sun, 3 Jul 2022 12:35:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: baolu.lu@linux.intel.com, "Raj, Ashok" , "Liu, Yi L" , "Pan, Jacob jun" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 10/11] iommu/vt-d: Use device_domain_lock accurately Content-Language: en-US To: "Tian, Kevin" , "iommu@lists.linux-foundation.org" , "iommu@lists.linux.dev" References: <20220629074725.2331441-1-baolu.lu@linux.intel.com> <20220629074725.2331441-11-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/1 16:15, Tian, Kevin wrote: >> From: Lu Baolu >> Sent: Wednesday, June 29, 2022 3:47 PM >> >> + spin_lock_irqsave(&device_domain_lock, flags); >> list_for_each_entry(info, &domain->devices, link) { >> - if (!info->dev) >> - continue; >> - > > suppose you can replace all spin_lock_irqsave() with spin_lock() > in patch5 instead of leaving some replacement to next patch. > Make sense to me. Will update this. Best regards, baolu