From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D019C43219 for ; Tue, 30 Apr 2019 11:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26C3F20675 for ; Tue, 30 Apr 2019 11:28:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727936AbfD3L2Z (ORCPT ); Tue, 30 Apr 2019 07:28:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54337 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726202AbfD3L2Y (ORCPT ); Tue, 30 Apr 2019 07:28:24 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7454A2D7F5; Tue, 30 Apr 2019 11:28:24 +0000 (UTC) Received: from prarit.bos.redhat.com (prarit-guest.khw1.lab.eng.bos.redhat.com [10.16.200.63]) by smtp.corp.redhat.com (Postfix) with ESMTP id 101506F547; Tue, 30 Apr 2019 11:28:23 +0000 (UTC) Subject: Re: [PATCH] kernel/module: Reschedule while waiting for modules to finish loading To: Jessica Yu Cc: Heiko Carstens , linux-kernel@vger.kernel.org References: <20190429151751.15424-1-prarit@redhat.com> <20190430075108.GA21092@linux-8ccs> From: Prarit Bhargava Message-ID: <49a246d0-3751-7d13-d7fd-01eac446b922@redhat.com> Date: Tue, 30 Apr 2019 07:28:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190430075108.GA21092@linux-8ccs> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 30 Apr 2019 11:28:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/30/19 3:51 AM, Jessica Yu wrote: > +++ Prarit Bhargava [29/04/19 11:17 -0400]: >> Heiko, do you want a Signed-off-by or a Reported-by?  Either one works >> for me. >> >> P. > > I think you forgot to CC Heiko :) #oops. I forgot that git-send-email doesn't pick up "Reported-by". P. > >> ----8<---- >> >> On a s390 z14 LAR with 2 cpus about stalls about 3% of the time while >> loading the s390_trng.ko module. >> >> Add a reschedule point to the loop that waits for modules to complete >> loading. >> >> Reported-by: Heiko Carstens >> Fixes: linux-next commit f9a75c1d717f ("modules: Only return -EEXIST for >> modules that have finished loading") >> Signed-off-by: Prarit Bhargava >> Cc: Jessica Yu >> --- >> kernel/module.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/kernel/module.c b/kernel/module.c >> index 410eeb7e4f1d..48748cfec991 100644 >> --- a/kernel/module.c >> +++ b/kernel/module.c >> @@ -3585,6 +3585,7 @@ static int add_unformed_module(struct module *mod) >>                            finished_loading(mod->name)); >>             if (err) >>                 goto out_unlocked; >> +            cond_resched(); >>             goto again; >>         } >>         err = -EEXIST; >> --  >> 2.18.1 >>