mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Hans de Goede <hansg@kernel.org>,
	 Pratap Nirujogi <pratap.nirujogi@amd.com>,
	 Benjamin Chan <benjamin.chan@amd.com>,
	 Mario Limonciello <mario.limonciello@amd.com>,
	 Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>,
	 Armin Wolf <W_Armin@gmx.de>,
	Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
	 Suma Hegde <suma.hegde@amd.com>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86/amd_isp4: prevent built-in configuration
Date: Thu, 26 Jun 2025 18:18:07 +0300 (EEST)	[thread overview]
Message-ID: <49a6a302-8660-5072-27b9-abc61253f608@linux.intel.com> (raw)
In-Reply-To: <20250620115448.202425-1-arnd@kernel.org>

On Fri, 20 Jun 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> Checking the module owner of the device only works when modules are
> enabled, and the device is created from a module:
> 
> drivers/platform/x86/amd/amd_isp4.c:154:28: error: incomplete definition of type 'struct module'
> 
> Building the driver as a loadable module avoids the build failure,
> though this should probably be fixed in a different way that still
> works if the device was created from built-in code.
> 
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506150313.UHoIoVhR-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/platform/x86/amd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
> index 63e4bd985699..9e150500e37e 100644
> --- a/drivers/platform/x86/amd/Kconfig
> +++ b/drivers/platform/x86/amd/Kconfig
> @@ -36,6 +36,7 @@ config AMD_WBRF
>  config AMD_ISP_PLATFORM
>  	tristate "AMD ISP4 platform driver"
>  	depends on I2C && X86_64 && ACPI
> +	depends on m
>  	help
>  	  Platform driver for AMD platforms containing image signal processor
>  	  gen 4. Provides camera sensor module board information to allow
> 

The fix series should finally be on its way to Linus through i2c tree. 
I'm sorry for the unexpected delay in getting the real fix applied.

-- 
 i.


      parent reply	other threads:[~2025-06-26 15:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 11:54 Arnd Bergmann
2025-06-20 20:02 ` Nirujogi, Pratap
2025-06-26 15:18 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49a6a302-8660-5072-27b9-abc61253f608@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=W_Armin@gmx.de \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=benjamin.chan@amd.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pratap.nirujogi@amd.com \
    --cc=suma.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®