From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78B7C433F5 for ; Mon, 16 May 2022 07:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240609AbiEPHBZ (ORCPT ); Mon, 16 May 2022 03:01:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236707AbiEPHAv (ORCPT ); Mon, 16 May 2022 03:00:51 -0400 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9CC5C46 for ; Mon, 16 May 2022 00:00:47 -0700 (PDT) Received: by mail-ej1-f54.google.com with SMTP id l18so26715372ejc.7 for ; Mon, 16 May 2022 00:00:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cR8Hsiy9clKxAsJER0JNovDFDdlOniNfgaMdZde7koY=; b=tJGAsYUBOQSJ9GLG9kezwefSDP58eZZFqFCwohpBvnFI7FWVSUikF6OXmbl+Yalgxt I8g0HLJqp9z7RDrbw6B4fMFPMfpMA3no8hnqjtNsRnJsCiD1/A94PaqfRC0aHyB+MXiL tekXKT/jobNRE/J/5DmHjJAwv2qJxWay6bThVVOg9hTFOmC3IDH6RDQOP2lOlbZLCicY r8mQWQlwOP0wTP6VM3OtK6UFZScUbHa8qGt14/wvHj34hLm8A0FS0AvhHcKLiTj0tFZs WEd/y37U9pfcv3CObitnXj0le0RQrKk7WQxZ6VIhSFWT9BpTxMPcA9pPcsJyqjEnj8T1 rhaw== X-Gm-Message-State: AOAM533tQurrSAF59Wc6K3aBJVj2fqWQMJHQF4j8Jw/RjOwQwEAgJbge B7TD5EOYwkNLJN3Oo7dP4vs= X-Google-Smtp-Source: ABdhPJxWecW7+gEwU5kLk6tc2W1Xkxx0zCkE55qr4QBIHuQKF26l3v5gIJ9e/R1zFbkUkNIF+LB7ew== X-Received: by 2002:a17:907:8a0b:b0:6f4:4899:db98 with SMTP id sc11-20020a1709078a0b00b006f44899db98mr14009750ejc.622.1652684446417; Mon, 16 May 2022 00:00:46 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id dq7-20020a170907734700b006f3ef214defsm3357616ejc.85.2022.05.16.00.00.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 00:00:45 -0700 (PDT) Message-ID: <49a7602f-dd79-cac3-e6e0-83c4c41fcd53@kernel.org> Date: Mon, 16 May 2022 09:00:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH -next v2] vt: defkeymap.c_shipped remove unused variables Content-Language: en-US To: Zhang Jianhua , gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org References: <20220513015427.569539-1-chris.zjh@huawei.com> From: Jiri Slaby In-Reply-To: <20220513015427.569539-1-chris.zjh@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13. 05. 22, 3:54, Zhang Jianhua wrote: > The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have > been initialized but not used, they are redundant and remove them. > > Signed-off-by: Zhang Jianhua > > --- > No code changes since v1, only remove the redundant line "--------" in > v1 commit message. > --- > drivers/tty/vt/defkeymap.c_shipped | 4 ---- The file header says: /* Do not edit this file! It was automatically generated by */ /* loadkeys --mktable defkeymap.map > defkeymap.c */ So I'm not sure anyone wants to touch it. > --- a/drivers/tty/vt/defkeymap.c_shipped > +++ b/drivers/tty/vt/defkeymap.c_shipped > @@ -185,10 +185,6 @@ char func_buf[] = { > '\033', '[', 'P', 0, > }; > > -char *funcbufptr = func_buf; > -int funcbufsize = sizeof(func_buf); > -int funcbufleft = 0; /* space left */ > - > char *func_table[MAX_NR_FUNC] = { > func_buf + 0, > func_buf + 5, -- js suse labs