From: Len Brown <lenb@kernel.org>
To: kbusch@kernel.org, linux-nvme@lists.infradead.org
Cc: maxg@mellanox.com, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: [PATCH 1/1] nvme: Use pr_dbg, not pr_info, when setting shutdown timeout
Date: Wed, 6 Mar 2024 20:05:41 -0500 [thread overview]
Message-ID: <49a7c0b667abe23d95d67cf0cf7ea7e193d9f2a1.1709773065.git.len.brown@intel.com> (raw)
From: Len Brown <len.brown@intel.com>
Some words are alarming in routine kernel messages.
"timeout" is one of them...
Here NVME is routinely setting a timeout value,
rather than reporting that a timeout has occurred.
Assuming this message is actually useful to somebody somewhere,
let's make it DEBUG level...
Fixes: 1a3838d732ea ("nvme: modify the debug level for setting shutdown timeout")
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0a96362912ce..e361af1953a4 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3205,7 +3205,7 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
shutdown_timeout, 60);
if (ctrl->shutdown_timeout != shutdown_timeout)
- dev_info(ctrl->device,
+ dev_dbg(ctrl->device,
"Shutdown timeout set to %u seconds\n",
ctrl->shutdown_timeout);
} else
--
2.40.1
next reply other threads:[~2024-03-07 1:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 1:05 Len Brown [this message]
2024-03-07 7:39 ` Sagi Grimberg
2024-03-07 9:28 ` Max Gurtovoy
2024-03-07 14:27 ` Len Brown
2024-03-07 15:17 ` Keith Busch
2024-03-07 15:23 ` Keith Busch
2024-03-07 16:25 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a7c0b667abe23d95d67cf0cf7ea7e193d9f2a1.1709773065.git.len.brown@intel.com \
--to=lenb@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®