From: Joe Perches <joe@perches.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
josef@toxicpanda.com, axboe@kernel.dk, houtao1@huawei.com
Cc: linux-block@vger.kernel.org, nbd@other.debian.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] nbd: add missing definition of pr_fmt
Date: Mon, 18 Jul 2022 07:32:21 -0700 [thread overview]
Message-ID: <49a8099eb7dd01e9d2d190056171341d87cd442b.camel@perches.com> (raw)
In-Reply-To: <853a5164-78cf-1ccb-8e18-cff5b5bce4ff@huaweicloud.com>
On Mon, 2022-07-18 at 21:52 +0800, Yu Kuai wrote:
> 在 2022/07/06 17:33, Yu Kuai 写道:
> > From: Yu Kuai <yukuai3@huawei.com>
> >
> > commit 1243172d5894 ("nbd: use pr_err to output error message") tries
> > to define pr_fmt and use short pr_err() to output error message,
> > however, the definition is missed.
>
> friendly ping ...
[]
> > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
[]
> > @@ -44,6 +44,9 @@
> > #include <linux/nbd-netlink.h>
> > #include <net/genetlink.h>
> >
> > +#undef pr_fmt
> > +#define pr_fmt(fmt) "nbd: " fmt
> > +
Typically, this #define is place before all #include lines
so there is no need for an #undef
next prev parent reply other threads:[~2022-07-18 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 9:33 Yu Kuai
2022-07-18 13:52 ` Yu Kuai
2022-07-18 14:32 ` Joe Perches [this message]
2022-07-20 11:46 ` Yu Kuai
2022-07-23 2:14 ` Yu Kuai
2022-07-23 2:15 ` Yu Kuai
2022-07-23 3:12 ` Joe Perches
2022-07-23 4:08 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a8099eb7dd01e9d2d190056171341d87cd442b.camel@perches.com \
--to=joe@perches.com \
--cc=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@other.debian.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®