From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8361F2032D for ; Thu, 29 Jan 2026 15:50:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769701831; cv=none; b=gGnnJ/FSmPuDMEFK2UGNsvmeqwsG0SoHTpNVQPWKGoHyLK7jyb2Vx/tnPaEgprY8xDubuG/QJg0Oy+mf973Xq85qgyA2Ke+KLqu+Y7xXY5jQ2wtxlaMd7ojpQzSsviHOVIjntbeAgKiiZlW0QmEom8fFROye5FfJp0nkQa2Zv1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769701831; c=relaxed/simple; bh=KhRISFZhCh2PBhuIa1I3iRGv9gWtlFhrslYGUwut7JI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qlS4zzvZqbAHxk6kR+SGuglfs7T4jDXFNHmx7JxrULUAaOYmJEe2ZX54RQLwfZ6UQ/TjOBSy5OD+crr7Lfwjx6CXX0kxuxzejarYZGUEOPvS9sBRXf6Y4dtsy7m9k537nMe5lIntDr84ralmvWv3o+3qBSJkv0zC8Udnmi5upB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=odwVmYOB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MW9lx+xe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="odwVmYOB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MW9lx+xe" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60T9v1JL2150660 for ; Thu, 29 Jan 2026 15:50:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vJw2Xxnpngqa4TD4UMnudb4MC0uCGRAj5VSnlg70YdA=; b=odwVmYOBKWCBkt1A 6TgAPJKndejKUV8a9eRQR4k6ZKUSC7t0sYEpX+qABFqPCDpo6wG+LxDEJxKphp+7 /CkThqP0rYZVIgsFqo1jtlNH85OKwMsOUfekT3800PoN1J5NadWJtEDxH7No1IV/ icBWKxBoapKzPp9vITAMbjXPfMwzYRQDdhlmSskZJKInqcNcMlQsrBdQH3281EHh JCqzniwzFXY6ec7aMcOeM+NQQGzHqfycA7Be+fk/djIbCTkoGPx90X6jrs/qLbr2 JjqwDaoojaNpEFWMpGkKVoVRrxwGCp+FIY7A7Us9WvBjeYFLGwsjiD5ih4LQy2E8 wvkgFQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byph3c2nt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 15:50:29 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b62da7602a0so810385a12.2 for ; Thu, 29 Jan 2026 07:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769701829; x=1770306629; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vJw2Xxnpngqa4TD4UMnudb4MC0uCGRAj5VSnlg70YdA=; b=MW9lx+xeb+f4jf0NMbY4Qej5AY5i9G2FKTSQzSNn0Wd+Luw+DNYr4n8l0WhVkrFXci KfLGa6+6R9U9pB40E4fBKCSK8YkqQBUHr+pAssq+nC6saO+5iNadsVzl21Y8p4e0EDr0 1QkowMCWp5LSh+48kluAvCrp2mTHfA8DvEzCkUUt/j1AuknycXDji+wmCAyF+LSlqQbf wTdZRd9D31PCk0mU7XE+FaI3RKmkToV901FtvOODTP1HrXu7MsrGNcDcqgvltkckFiDK OE7IXKtsHM2cYzst26Zzt9JHg/bwXw+M/U/Qe93pRLIeuelcGxOUUrs5b0KVS1UtsBOT 4wtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769701829; x=1770306629; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vJw2Xxnpngqa4TD4UMnudb4MC0uCGRAj5VSnlg70YdA=; b=QncQbuT/hFjiRkczItNgxCcgObnRLGWL2Zjw+ARSOv4bY/4I9cr89ASXeQPiNbcGe1 4KMNCpYl2kIPn6yeWxxkdi/XKBE+hQNQE9ISeYARsIleul+JTB4CQglaUht6W3KK6A+7 lFQz9toEXVQGb1XN/YoI4NtewFX6MCPG/5FKFSNgpALWljjU8iZwgWimeHIlnVwCsWK3 /uLLfLVD4xb+t2hxe5N7gE0ww/Y8feONjGhWHpDxWzOwsbyMQiyWoM/MM8CELNBDs3do S12ssS/ByaQlNnZbixn3FxLNEkndaUV0P5CvXOja6Nw9PcNGeG4gX7WYH5Yi1VACfQFV ha+g== X-Forwarded-Encrypted: i=1; AJvYcCXWcboPojG2G5PtUMGgO+3vH8fyWBeNEhxIRPs1axL14zvYoHH/u/BMYTWN+e4pY73T3Hc/DJhyotpmEWo=@vger.kernel.org X-Gm-Message-State: AOJu0YwqPBFDCiBt3lEL3WEqrbBvoQkp26X11MhagnfMQ0gENVG60DqE IcJ0NLWLsziEuHlwC9j0nkiJlAgCFjknaVLlEDEkrlpjluU3Zlgr5XJ6mE6EwliJzrPJP43S6K+ co/49779HcQt4P3gYse2iGM7wDU5K/QKjgZaGkiaa1KcaLvNuX7h3f4R2Sarb2RBkGkU= X-Gm-Gg: AZuq6aJIPmKNrfTbMa7cPfcSY4E4KYZYChrTs44/CmSov5aUWqC+m33aiI7EL/ovc1o X6NCXRKwuBx27J23O7MsRDnZ6gMAtC9kGZq+l2ahQLVGXpycwXZg3AzgaTfTbKC40HLzDSlD2Nq Gxe9KKNpaB8Io5DgFr2FsBdc4MKquG92cjfnzILWXOB2wsGsVILc+NPv2bu2eQVvxv1dVYsWn7d YxUqLXXCcSYFesP87GdejLKxybDb87H9B8sof6iWarY0qeC/ikHGwkmYLYhclLSmAd+YAU5E/sW LRbLtZjqERsPjUsHOOG66srYja0e3VQ41tD5dqxt8u80Sz79VRM1AOUKe2NKt+LQxPOCnDtPtSE jY8aDU+s6QwUUwBm0XmRt459KrLj8mua79ukkIx8y9w== X-Received: by 2002:a05:6a00:9295:b0:81d:70d9:2e96 with SMTP id d2e1a72fcca58-823692c4b64mr9972771b3a.54.1769701829037; Thu, 29 Jan 2026 07:50:29 -0800 (PST) X-Received: by 2002:a05:6a00:9295:b0:81d:70d9:2e96 with SMTP id d2e1a72fcca58-823692c4b64mr9972742b3a.54.1769701828472; Thu, 29 Jan 2026 07:50:28 -0800 (PST) Received: from [192.168.1.2] ([49.204.110.251]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfd71csm5733189b3a.35.2026.01.29.07.50.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 07:50:27 -0800 (PST) Message-ID: <49ad7aa9-ac4f-45b3-9b77-8902b414f0d5@oss.qualcomm.com> Date: Thu, 29 Jan 2026 21:20:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] spi: geni-qcom: Add target abort support To: Konrad Dybcio , Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> <20260122151008.2149252-4-praveen.talari@oss.qualcomm.com> <64961e27-e316-47d1-8ab4-c4868754adb6@oss.qualcomm.com> <700e3ce3-776f-4ee7-86e2-40608deffc0d@oss.qualcomm.com> <7c0883eb-3147-4b83-908b-b5c0ff909481@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: <7c0883eb-3147-4b83-908b-b5c0ff909481@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=Z93h3XRA c=1 sm=1 tr=0 ts=697b81c5 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=hmzEZbfuJy6/QR5cQt8XuQ==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fMn5tOcbCyIVrqCJyPMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: -i2akIicBJrLVkqD1-ao6Ucz1Fdy9Fmq X-Proofpoint-GUID: -i2akIicBJrLVkqD1-ao6Ucz1Fdy9Fmq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDExMCBTYWx0ZWRfX1hcTrmT8Ac/i AyeNLC5eksjAJqPRdY5CL61diwFytuEs5XdIfoe3RVio2sRHlfK4J4ee/IzIwhi1KaIqmBBVDwD F5QZB4eZ0AVT9f1s1uPfwK8LSmG5Q2Oqx/cfKVCGlrBk/pCFv3IU+99seGb0QFDzvGzgFM2fZmc ZpThmJFznQA6lwv4vzH7cZbLeoCkbxi3tgKIJ0FQ7eyb1MsOrb40uEYiVdDTlvdAtHo5oVDLRy5 FPde/6OLSMCRDbP3tdJAZFsBEmshtdVBq8uIl29FxQmlch8A85mivB4B1gldcoCr6XrM/UYdsGB LzfQKgVVVsZ0MNu9Wt0wkX2XgiTsnbjuHhGWqzQMD5BEJeKuEeHITIpHPNMkZ5xC779BFSzFkGg DN//jTTxiBDqzYjJUVF8KBcAy07WNksLNkfS+r/61+4BezgtC/Kqpy6DJub3WeZ1wh/0tAzQfYI LS6YNOK+zX6Xa6iu61w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290110 Hi Konrad, On 1/29/2026 5:12 PM, Konrad Dybcio wrote: > On 1/28/26 5:28 PM, Praveen Talari wrote: >> Hi Konrad >> >> On 1/27/2026 6:51 PM, Konrad Dybcio wrote: >>> On 1/22/26 4:10 PM, Praveen Talari wrote: >>>> SPI target mode currently lacks a mechanism to gracefully abort ongoing >>>> transfers when the client or core needs to cancel active transactions. >>>> >>>> Implement spi_geni_target_abort() to handle aborting SPI target >>>> operations when the client and core want to cancel ongoing transfers. >>>> This provides a mechanism for graceful termination of active SPI >>>> transactions in target mode. >>>> >>>> Signed-off-by: Praveen Talari >>>> --- >>>>   drivers/spi/spi-geni-qcom.c | 14 ++++++++++++++ >>>>   1 file changed, 14 insertions(+) >>>> >>>> diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c >>>> index e5320e2fb834..231fd31de048 100644 >>>> --- a/drivers/spi/spi-geni-qcom.c >>>> +++ b/drivers/spi/spi-geni-qcom.c >>>> @@ -1009,6 +1009,17 @@ static irqreturn_t geni_spi_isr(int irq, void *data) >>>>       return IRQ_HANDLED; >>>>   } >>>>   +static int spi_geni_target_abort(struct spi_controller *spi) >>>> +{ >>>> +    if (!spi->cur_msg) >>>> +        return 0; >>>> + >>>> +    handle_se_timeout(spi, spi->cur_msg); >>> >>> I can't help but notice this function never even dereferences this >>> argument >> >> Yes, you’re correct. Since the argument is never dereferenced, it is safe to pass either cur_msg or NULL here. > > Would you like to send a patch removing the unused argument? Sure, will update new patch in next version. Thanks, Praveen Talari > > Konrad