From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E3A532939A for ; Tue, 16 Dec 2025 22:41:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765924867; cv=none; b=rqIstjV2pbDI6qgPU/jyVJtkonQRls7arO97b4enTp8EONI2MbJh6M5eHdOmOqwCnizA5LpUhtaJhZ2O8KZWdhkyG36RHNY9SxPFbjHEo4BUTrlweg1gguYAhBvFg8yIr9zEJO2nBvCAomwUrKGguxov7IFbo87xD3pFaZM2qNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765924867; c=relaxed/simple; bh=96pavKuE2aINzdEYpQ/slR7/qIuE9K5cfsZo/RAh5V0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KgqFKsXpZF0/j8jnVD8sEwFoFJEJSsCnXdMBHZjclUlIXs/QRYXurtpU554cQvsjhF3T2tP3jrXK1XJGtPOn7qxVHMBxT/l63a+K+8Qjpu/VKEHhF+2LRhQCzLEj+FG8IUW27Ei2Y75dDU3NfGH3vgxgyIh0selhAdrLkXJpRwc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZIdESS+p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZIdESS+p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C998CC4CEF1; Tue, 16 Dec 2025 22:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765924864; bh=96pavKuE2aINzdEYpQ/slR7/qIuE9K5cfsZo/RAh5V0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZIdESS+pCtNV7hdsHai4Ph/cEZY1dWHyNd2DPFjYxOplsv2u6oZ56DHaqH3H6xbYN si9jEhV1kv5aySLaKtC3J6Bb/VhE/kHXyks6uKek6M2zyi+xIqlxbwhWE16rHXT++l yOwBHW1uDG7jz2wKwni9G0B1li78zB5Vw+L0hj9sMI4muJQuMAgAqkMB6sIaQaTOB7 Oibv8ueBSZZ7eCrHaDRdKe7Wdw6Ra2vJ39mmyy9oGbVMIX8K+R5utrDq53NkGjLrBZ P88+33uP/0FsyxJrtZeWxBNcpyiooj/QoecMKK9K6AeGlGBc2lIyH/2K88BQCdWD4P BJRUHQZxw0wzw== Message-ID: <49b2a51b-a324-4a8b-b6e8-434fcc411b19@kernel.org> Date: Tue, 16 Dec 2025 23:40:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/8] powerpc: Prepare for IRQ entry exit To: Mukesh Kumar Chaurasiya Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, oleg@redhat.com, kees@kernel.org, luto@amacapital.net, wad@chromium.org, mchauras@linux.ibm.com, thuth@redhat.com, sshegde@linux.ibm.com, charlie@rivosinc.com, macro@orcam.me.uk, akpm@linux-foundation.org, ldv@strace.io, deller@gmx.de, ankur.a.arora@oracle.com, segher@kernel.crashing.org, tglx@linutronix.de, thomas.weissschuh@linutronix.de, peterz@infradead.org, menglong8.dong@gmail.com, bigeasy@linutronix.de, namcao@linutronix.de, kan.liang@linux.intel.com, mingo@kernel.org, atrajeev@linux.vnet.ibm.com, mark.barnett@arm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20251214130245.43664-1-mkchauras@linux.ibm.com> <20251214130245.43664-7-mkchauras@linux.ibm.com> <91d280af-fb41-4c05-8b96-113717ecd64a@kernel.org> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 16/12/2025 à 16:00, Mukesh Kumar Chaurasiya a écrit : > On Tue, Dec 16, 2025 at 10:58:16AM +0100, Christophe Leroy (CS GROUP) wrote: >> >> >> Le 14/12/2025 à 14:02, Mukesh Kumar Chaurasiya a écrit : >>> From: Mukesh Kumar Chaurasiya >>> >>> Move interrupt entry and exit helper routines from interrupt.h into the >>> PowerPC-specific entry-common.h header as a preparatory step for enabling >>> the generic entry/exit framework. >>> >>> This consolidation places all PowerPC interrupt entry/exit handling in a >>> single common header, aligning with the generic entry infrastructure. >>> The helpers provide architecture-specific handling for interrupt and NMI >>> entry/exit sequences, including: >>> >>> - arch_interrupt_enter/exit_prepare() >>> - arch_interrupt_async_enter/exit_prepare() >>> - arch_interrupt_nmi_enter/exit_prepare() >>> - Supporting helpers such as nap_adjust_return(), check_return_regs_valid(), >>> debug register maintenance, and soft mask handling. >>> >>> The functions are copied verbatim from interrupt.h to avoid functional >>> changes at this stage. Subsequent patches will integrate these routines >>> into the generic entry/exit flow. >> >> Can we move them instead of duplicating them ? >> > Till we enable the Generic framework i didn't want to touch the already > used code path. Once we enable the code all the unused code should be > removed. This helps us in bisecting future issues caused due to this. I can't see who it can help bisecting. What did I miss ? If you copy the code, you don't know whether what you have copied is correct or not until you use it. So when you start using it you don't know if the problem is in the copied code or the code using it. If instead of copying the code you move it and continue to use the moved code from the only implementation, they when you start using it with the new code you are sure it works and then if you have a problem you know it is not the moved code but the new code using it. Christophe