From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D8BB426D36 for ; Wed, 21 Jan 2026 16:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769013846; cv=none; b=pNZ5qfOuN+z9Ho3BexFt20LD6x8vUCVrUJDc8RS/9Rr1hV2k4OEwMWZf03pHFYFKrDN68OMyi8IEKqXQ9OGUDa8dur7ot+FxyQpeUsBNZNdEILWkI2kM7MGsJAcQvPG8rpOPX/2JCmTHnOC3dapDq3hEzU71YneQMqVDIAOIjJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769013846; c=relaxed/simple; bh=i/jcJbK4ycETd+rUvQz4ZeLeFmTXeuR88Ha0X44aYvE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=HJ3frwsZIlP6YJqkSiz+8F7C1C7+VkB20JczqIooF4mvfcBE00ii6+pe8XGL5kPpoPasu13rrJ/O23PR0ng0KgcjOCbAA+QYADJujFE+pgL3U0rc+BHMygZYdoV1+OzZwu+Un6iyR10bTipFold3pal/I6v4vSWf5uSo45MkvCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q7Afnigz; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q7Afnigz" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa9so13939f8f.1 for ; Wed, 21 Jan 2026 08:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769013843; x=1769618643; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=1myAXTRCFyNcgADPfwfjEtstkbzJqQQ7A3560oXOVyw=; b=Q7AfnigzLOJfcHhzuYT4+pal81sCN8aV0N9Mg49Iy0nS5xDwmT+un7kQizUoTLMQ+k Jj8TT9MKCe18E2x/87MZy/Fbv2Ds8XwH9V9ueaIjap4e40n4Izn+RT+pw5NWRM47aQz8 YuO92OVV5bttP4YlZ720Cv2nnI5ndDvwhga4rxz0ZGd3SPB8KshtKrR4B75xJrmxDM61 zTU88DsGm6Ms9HOOyFxE4Hg4zZbYRSQnFhGyC4nnEfbAnEmUDnWwzWg/Jqn2H1Hwvh/3 k/d7+Yue0See1NUcADkwvfXyXNfMTJHbyX0RvAyI3BOuJqmZv9Ug3fajtGF7oZq25I4o d3Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769013843; x=1769618643; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1myAXTRCFyNcgADPfwfjEtstkbzJqQQ7A3560oXOVyw=; b=rWH46lwQhGLTEedD3U5VhusxuZmSbcJAtP+bitFt5o+USvPw7oW575O74ZcinX7W+l iB8l7hTFDaw+WYrpeyNM+Shc+JH4KXctloI40XoOQqnkXlw6L7T96rjFON3FYg58WnE+ qpijFcwPhPHceONhoIK7PFLteiAkd9kEK9Qw1ME3PRuw2lnCHgpRj5u2fG1lih/6DPqb JE1wjrlxK6TUT9d+7oRQKIdIqwfU4F2llXK4d506llyXSvXUGLxOQJInGG9Ikn3c1A9g BrJ719AqXpom1ovT9V1Rk2newgP9sybGLx5IjWrHBU3EkzwIXYBW5YWyloGMrBxHNMn1 M5qQ== X-Forwarded-Encrypted: i=1; AJvYcCXY38WaJx4LhlFk3AMREmt3Hwp442AEtw15fk7dYR+3IH+YJ03djSanrJYA/FHu+AUFim+UQyhYOZLv7UQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+vCrhycPZfmrenU5zF9tzSUUp+9MsEzQvcylXFq7EIQvCTJty tZdDAqso0HZvAfUc6GRzkKqKaAn0qNDAET/XuvWzwBhvMyW1R7WeVYKMmamy3W00mvI= X-Gm-Gg: AZuq6aKUaf9xdfZlGUgruOBT5v7pB+B30rj38DyAIiKlnOkLig8Wj0ZtjJifsF86hMH Yt/+9Xki2PRiX6d9+yVmb1UvvdJfv1hw9xS6vzC0hjsj7bZ0FeTN1krBCdR4D4BDs2NnE1l+xNs 6zCuxKg5Peyxb7XUpQI1t3gJcxfIVzjutPdImqzMYr1p/PPPCDr5prbY90kCX6fnMdavbbYqhwg wyF4dp5A2dHh66F/QNdKrPH0Mxs8Gv+SB+T8gN2j9jEC8+WmtK7Wj/MI2MyvJ/BOgY0Abk+H06m spLTUF0oLX/WoKEUr3RRNVTbz/ypwmzNzNEvlXrUcF+B6kiyma3BJ+y2IJhj5k2/41cKOfW+bpI 3DZPukwN0SLcvELGnLfZ+rrajH2gcImrzj2+dwnL1nQpN9EqEs8YkcMLfUyhMFZTmOeh5R2mtCT BvmoyQewhd7jvJEuASQlmWTahwzUgA6Ci6i9WYBHZYwF2WHCgLtOuoNWx5kzfLG0M= X-Received: by 2002:a05:6000:310e:b0:435:99d5:9d8f with SMTP id ffacd0b85a97d-43599d59f09mr5736496f8f.19.1769013842720; Wed, 21 Jan 2026 08:44:02 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:8ae8:f59d:ae95:f372? ([2a01:e0a:3d9:2080:8ae8:f59d:ae95:f372]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4358f12ee69sm14755862f8f.11.2026.01.21.08.44.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jan 2026 08:44:02 -0800 (PST) Message-ID: <49b62589-111d-4d4b-b693-466e0a2f81eb@linaro.org> Date: Wed, 21 Jan 2026 17:44:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2] arm64: dts: amlogic: meson-s4-s905y4-khadas-vim1s: enable SDIO interface To: Nick Xie , khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, xieqinick@gmail.com References: <20260121014725.122722-1-nick@khadas.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260121014725.122722-1-nick@khadas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/21/26 02:47, Nick Xie wrote: > Enable the SDIO controller interface connected to the on-board > AP6256 WiFi/BT module. > > Signed-off-by: Nick Xie > --- > Changes in v2: > - Dropped 'amlogic,dram-access-quirk' property as it is not required for S905Y4. > - Updated compatible string to specific "brcm,bcm43456-fmac". > - Link to v1: https://lore.kernel.org/all/20260116023900.2036657-1-nick@khadas.com/ > > .../amlogic/meson-s4-s905y4-khadas-vim1s.dts | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts > index 4a66c1bec965e..27d0f6134ea9d 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts > @@ -220,6 +220,33 @@ &sd { > vqmmc-supply = <&vddio_sd>; > }; > > +&sdio { > + status = "okay"; > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + #address-cells = <1>; > + #size-cells = <0>; > + bus-width = <4>; > + cap-sd-highspeed; > + sd-uhs-sdr50; > + sd-uhs-sdr104; > + max-frequency = <50000000>; > + non-removable; > + disable-wp; > + > + no-sd; > + no-mmc; > + mmc-pwrseq = <&sdio_pwrseq>; > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_ao1v8>; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm43456-fmac", "brcm,bcm4329-fmac"; > + }; > +}; > + > &spicc0 { > status = "okay"; > pinctrl-names = "default"; Reviewed-by: Neil Armstrong Thanks, Neil