From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64BB4442B34 for ; Thu, 20 Aug 2026 12:35:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787229340; cv=none; b=FkuM8WptW8HYnoCUEP99t0xL6ZpcDrwKGLr82fYG61EViqm79QSKINnjVweSWWqmXhtno2NLyZ0XNkpVwWL+rRQqdWamwfxnYkrUqK/ugdjUhf7v0lb5QcFVj9I1V9ocde0hJmvlnrmGuJrxXKkLvYWLELROTC+z9Z0/qNFoHs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787229340; c=relaxed/simple; bh=zLJG/f14PS8IWMmKFHbSudOFvttrq1FN6y5gEITIHpQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gueb875j6a7L7BbbSnhbwArYVCy1nHRvgm6u3llmBCniwqeHYN5IbAQt42K0cUjTRSGGGE2L+hNcW7GGfHgDpI8LJ0BMUKRkNW0YjVlmCgPQlPpL4b7r9FUid/y0/V4I9d7QZUc1mW8aH+ire93D/m8teINfGXViwNHLD5WMzj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WCOjQ2Yz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PA0Po746; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WCOjQ2Yz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PA0Po746" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67KAOtqk2214561 for ; Thu, 20 Aug 2026 12:35:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nvhd0zZOpOWlXPQG6hjDdSgimOp5ylGte8t4ByQ3TVI=; b=WCOjQ2Yz+ctme2+G 930MCKEQixYauFh2behIj4WORi+WRFrD3VgbG1s99Kr2Pwb/PBdfapRnmaVz7gdm ZrL++AdweLK1nyEN26K6779di+4MSP/UI3+YYyXFsKPu4xj5VhFER/AkCmLhYu9L UteIYKBg1uaPrldwpi6HNrkkUo0ozmKui9U9NWI5IQj0qr2ja7aIBgt2zkbz+0xJ e9wi9+3PRSo8PLHwZtx0+MG9D3OxdHMMU+KmjbMYzwz3/qDNcUnF1g5FxyO7qKhb zCCOFv/O5H512wkqgknQuP0eWbVnlPjhmAZrulvz9OUZfLDz7CRs/nMdkkqS3qlS 3qzz4A== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5ytc8ebv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 12:35:38 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84e048a801dso2922572b3a.3 for ; Thu, 20 Aug 2026 05:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787229338; x=1787834138; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nvhd0zZOpOWlXPQG6hjDdSgimOp5ylGte8t4ByQ3TVI=; b=PA0Po746V9ydMk1cYNPRnsAxf5UPB5dF7C1FPnC3d8xDPBSQXez9Utg9NaKpKWiHjk gkeTEk3SwGu1XvCgniEgtZ0k0r32Ju1NOL8TjSa98mMearhRkQAgkxyrr3zbSD3YU+vK ouyDbMzy+A21WvMYwBrorLi3BR+NBwVQylKqved/P/uT97UviiGjbPIj8N26i+l8Sg88 M4yOypcod/gGBNvHP+jlo66azQfW6LmKV1r1TLgVmV6nNl0ktlgXtcuWcZL729JHHDhC WeIJ9VB7j7LCFZcbkTR0uNJ0D64fVqhcsiaIKtm6X5/Nu5zQrj9KsF+ZOQNOYJohr62W pCYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787229338; x=1787834138; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nvhd0zZOpOWlXPQG6hjDdSgimOp5ylGte8t4ByQ3TVI=; b=nY7O/T1gZP17o6XsHyfwXQSki7F4pPN//dBW6Sqgyr9UXnrFEA00Uaf6WM+pahbMbV EZbxk+f2n1k2geS5s0Z0OfETiwvzIc3bWV/B/LUQD3JP4RKaxhUqepeYI49EidUSrEpP RoVmNv5TdHAP3GZF+RInzDuDOEU3xo77I21XGVR/anJQaYiv348LgZfg/i3WIlrTT0M8 c7gqMA9lgw+a8SrVPcDzYmaivflpJLXI3kXcUs2enj8/dAcJPeUcy95EWEJYvv6olE55 +oqZRc5s9jzreBiDCJM1S2Nd9Ps+z+PpCBLWoxrLy00MTd8JYcpdiWiBTi3ruJYYub+V C9jw== X-Forwarded-Encrypted: i=1; AHgh+RoJ5S5TPE5okFQrVA/3VIxl0TBsZnsjEUkYmUhcDO6MJTx41UFJDX0QAJFtLhU5jlsSdMNKHzPUkSTw7eg=@vger.kernel.org X-Gm-Message-State: AOJu0YwuVT1p3Z9OI8L810Uf//ohnqe1bCrxrZFHI7SS+361oHTjsQ72 qUxtcqyojs7Bwrm25P5zfMfCxZvzA9JOsiMuo120AoTajwmgD8tfpr2nxtp7PAGV33mYNgWS6cc Q4kpIa6/sDTUh0Ae/EziHoaxgmhJjPm/9EpADHD64tHUkyqhY4M9UxcWgV0TuebduxxE= X-Gm-Gg: AR+sD10o+mRwUUqDILx9AdETqOmDwnFHSKCEGLMbyltXX3QY+ZupWA3qhiWooFUL3p7 AAQLmGQ3dZpzerML65gV1ttfLb49Lmvu7IPmzVYRjQ7XhxkPEf7USZddaoXNXphKK1UdBudFqM2 ec0jOxV2avMkF9U++iKW0BSpj2eNMQGRrBh0TM3YjrNVOoGCkwA5hsTnhqfkeY5tYVcGhbfMtzp Wzu1Ls6pjt9EU+iemQ7OH0zxqhVd+2hRCGFiAIg8eBrUHkMAQdN+NxKMR/P65egkhj8Sdpl29WK T/VB3by8Y6CZme6JqM7Vnh4MulxVrNCivOCuEYXAGxsgDMH968M8woCbECHCug9Yap8yEaguCeG igc9y0mRC8jf8tdD83wNkJ/+JxnaWG8PWj9ZTcVHu7Huwpm89KP7rGsYyIbynWjCtnLbC+/sy X-Received: by 2002:a05:6a00:4c11:b0:84a:29a7:f650 with SMTP id d2e1a72fcca58-851d348dd44mr21853615b3a.0.1787229337974; Thu, 20 Aug 2026 05:35:37 -0700 (PDT) X-Received: by 2002:a05:6a00:4c11:b0:84a:29a7:f650 with SMTP id d2e1a72fcca58-851d348dd44mr21853463b3a.0.1787229337347; Thu, 20 Aug 2026 05:35:37 -0700 (PDT) Received: from [10.133.33.112] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc1556753b7sm1768171a12.16.2026.08.20.05.35.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 05:35:36 -0700 (PDT) Message-ID: <49b8a931-f814-45c1-97f4-cbb825dec700@oss.qualcomm.com> Date: Thu, 20 Aug 2026 20:35:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] cpufreq: loongson3: Replace per-package mutex with per-node To: Huacai Chen , "Rafael J . Wysocki" , Viresh Kumar , Huacai Chen Cc: loongarch@lists.linux.dev, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Xuerui Wang , Jiaxun Yang , stable@vger.kernel.org, Hongliang Wang , zhongqiu.han@oss.qualcomm.com References: <20260818123921.3600606-1-chenhuacai@loongson.cn> <20260818123921.3600606-4-chenhuacai@loongson.cn> <3f352680-7090-456a-ab08-2d3367641783@oss.qualcomm.com> Content-Language: en-US From: Zhongqiu Han In-Reply-To: <3f352680-7090-456a-ab08-2d3367641783@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=OqZ/DS/t c=1 sm=1 tr=0 ts=6a86f49a cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=LayQR5MyJkDDx0UqswYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDA5MyBTYWx0ZWRfX8//w9xgKVvTm pPp9c1sLCYWpkemD5E9hy3yPIH8iqdd95+MVNHeb3Qa3jfv7w8kCGoiNdZYNzY5cmYXLOIUM/Fg KtqRahJZ+Yi/ZsoZMSHfvMS5BcrLqs8nzdzBVDyVKh2IPATzi29UmDEl37V5yjrJnnAVaKUzfPt E5Or0Okj8YVIlXFbPo9uNWYzMD8BXlAvAh0LY9Kggz26hbmGQJZlrVRXoYr3UkgzoS2i+oviQHC +ZrLnwHFwv6jT50ezXIq4b3bYiN2oIjP3C+z9DAxtH/SFHAym/ZY/Cx3IypIcxutAetyXNjmlA0 pBYIN5fIVJ5nd4cjV924AoCgmQThKw5/QzXtFUez80PCuXvi/wu+W83BSmwoZnWkUq5AF4ppzlC vhpxDYVc7xR1ia6YOQU8TSIP8PLz6pT3pjF45y8qL9dZu78QuTe9B4wtiTyMhQTUEQ7+T9lMJ88 7aA9qfPSfadsWFW6Eug== X-Proofpoint-ORIG-GUID: LRe-5RULsNVXeXwwUfKzQo0CbVRMxSr7 X-Proofpoint-GUID: LRe-5RULsNVXeXwwUfKzQo0CbVRMxSr7 X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDA5MyBTYWx0ZWRfX6AQ44CMzEkbR uT2bL8NcwHb4hiAb8zR+WffkbL1BnIwKWT8/RSWzCemYuwgSOiTpy3tN08/gT2aHNBeAtVSQcUH XZYTl8AVNeou5wNDy7ag8Dgliyhjc4M= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 malwarescore=0 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200093 On 8/20/2026 7:34 PM, Zhongqiu Han wrote: > On 8/18/2026 8:39 PM, Huacai Chen wrote: >> Our server productions (e.g. Loongson-3D6000/3E6000) can have multiple >> nodes in one package and SMC mailboxes are also per-node. So replace the >> per-package mutex with per-node one. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Hongliang Wang >> Signed-off-by: Huacai Chen >> --- >>   drivers/cpufreq/loongson3_cpufreq.c | 14 +++++++------- >>   1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/cpufreq/loongson3_cpufreq.c b/drivers/cpufreq/ >> loongson3_cpufreq.c >> index 630f679aa739..e3cd78a5ab18 100644 >> --- a/drivers/cpufreq/loongson3_cpufreq.c >> +++ b/drivers/cpufreq/loongson3_cpufreq.c >> @@ -169,7 +169,7 @@ struct loongson3_freq_data { >>       struct cpufreq_frequency_table table[]; >>   }; >> -static struct mutex cpufreq_mutex[MAX_PACKAGES]; >> +static struct mutex cpufreq_mutex[MAX_NUMNODES]; >>   static struct cpufreq_driver loongson3_cpufreq_driver; >>   static DEFINE_PER_CPU(struct loongson3_freq_data *, freq_data); >> @@ -177,14 +177,14 @@ static inline int do_service_request(u32 id, u32 >> info, u32 cmd, u32 val, u32 ext >>   { >>       int retries; >>       unsigned int cpu = raw_smp_processor_id(); >> -    unsigned int package = cpu_data[cpu].package; >> +    unsigned int nid = cpu_to_node(cpu); What if NUMA is disabled? >>       union smc_message msg, last; >> -    mutex_lock(&cpufreq_mutex[package]); >> +    mutex_lock(&cpufreq_mutex[nid]); >>       last.value = iocsr_read32(LOONGARCH_IOCSR_SMCMBX); >>       if (!last.complete) { >> -        mutex_unlock(&cpufreq_mutex[package]); >> +        mutex_unlock(&cpufreq_mutex[nid]); >>           return -EPERM; >>       } >> @@ -208,11 +208,11 @@ static inline int do_service_request(u32 id, u32 >> info, u32 cmd, u32 val, u32 ext >>       } >>       if (!msg.complete || msg.cmd != CMD_OK) { >> -        mutex_unlock(&cpufreq_mutex[package]); >> +        mutex_unlock(&cpufreq_mutex[nid]); >>           return -EPERM; >>       } >> -    mutex_unlock(&cpufreq_mutex[package]); >> +    mutex_unlock(&cpufreq_mutex[nid]); > > An optimization independent of this patch: considering to use > guard(mutex)(xxx.lock) > >>       return msg.val; >>   } >> @@ -337,7 +337,7 @@ static int loongson3_cpufreq_probe(struct >> platform_device *pdev) >>   { >>       int i, ret; >> -    for (i = 0; i < MAX_PACKAGES; i++) { >> +    for (i = 0; i < MAX_NUMNODES; i++) { >>           ret = devm_mutex_init(&pdev->dev, &cpufreq_mutex[i]); >>           if (ret) >>               return ret; > > -- Thx and BRs, Zhongqiu Han