From: yuzhe <yuzhe@nfschina.com>
To: Marc Zyngier <maz@kernel.org>
Cc: james.morse@arm.com, alexandru.elisei@arm.com,
suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
liqiong@nfschina.com, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings
Date: Tue, 29 Mar 2022 15:26:11 +0800 [thread overview]
Message-ID: <49b93407-dee3-b3bb-6d36-d6f94e9b16bf@nfschina.com> (raw)
In-Reply-To: <87r16li6e7.wl-maz@kernel.org>
在 2022/3/29 15:07, Marc Zyngier 写道:
> On Tue, 29 Mar 2022 07:14:16 +0100,
> yuzhe <yuzhe@nfschina.com> wrote:
>>>> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
>>>> static int vgic_debug_show(struct seq_file *s, void *v)
>>>> {
>>>> - struct kvm *kvm = (struct kvm *)s->private;
>>>> + struct kvm *kvm = s->private;
>>>> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
>>> How about you fully get rid of the unnecessary casts then?
>>>
>>> M.
>> I don't know what you exactly mean. I follow the
>> kernel-janitors/TODO List to get rid of the unnecessary casts. And
>> I checked all the code in the arch directory and found these issues.
> Let me quote the lines again:
>
>>>> static int vgic_debug_show(struct seq_file *s, void *v)
> [...]
>>>> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
> Do you see what I mean?
>
> M.
Got it, thanks. I will check again and resubmit.
yuzhe
next prev parent reply other threads:[~2022-03-29 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 10:38 yuzhe
2022-03-28 13:36 ` Marc Zyngier
2022-03-29 6:14 ` yuzhe
2022-03-29 7:07 ` Marc Zyngier
2022-03-29 7:26 ` yuzhe [this message]
2022-03-29 11:21 ` Dan Carpenter
2022-03-29 10:20 ` [PATCH] KVM: arm64: vgic: " Yu Zhe
2022-04-06 13:22 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49b93407-dee3-b3bb-6d36-d6f94e9b16bf@nfschina.com \
--to=yuzhe@nfschina.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®