From: Paolo Abeni <pabeni@redhat.com>
To: Wen Gu <guwen@linux.alibaba.com>,
richardcochran@gmail.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org
Cc: xuanzhuo@linux.alibaba.com, dust.li@linux.alibaba.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] ptp: add Alibaba CIPU PTP clock driver
Date: Tue, 22 Jul 2025 11:13:40 +0200 [thread overview]
Message-ID: <49c4e674-ab1e-4947-9885-5c73810368eb@redhat.com> (raw)
In-Reply-To: <20250717075734.62296-1-guwen@linux.alibaba.com>
On 7/17/25 9:57 AM, Wen Gu wrote:
> +#define PTP_CIPU_BAR_0 0
> +#define PTP_CIPU_REG(reg) \
> + offsetof(struct ptp_cipu_regs, reg)
Minor nit: no need to use a multiple line macro above
[...]
> +static void ptp_cipu_clear_context(struct ptp_cipu_ctx *ptp_ctx)
> +{
> + cancel_delayed_work_sync(&ptp_ctx->gen_timer);
> + cancel_delayed_work_sync(&ptp_ctx->mt_timer);
> + cancel_work_sync(&ptp_ctx->sync_work);
You need to use the 'disable_' variant of the above helper, to avoid the
work being rescheduled by the last iteration.
Other than that LGTM, thanks.
Paolo
next prev parent reply other threads:[~2025-07-22 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 7:57 Wen Gu
2025-07-22 9:13 ` Paolo Abeni [this message]
2025-07-23 13:18 ` Wen Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49c4e674-ab1e-4947-9885-5c73810368eb@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®