From: Thomas-Mich Richter <tmricht@linux.vnet.ibm.com>
To: ast@kernel.org, Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: struct pt_regs missing in /usr/include/ tree for eBPF program compile
Date: Wed, 2 Aug 2017 13:22:36 +0200 [thread overview]
Message-ID: <49c5e39b-a7d9-1e2d-24ec-57852f7d1e51@linux.vnet.ibm.com> (raw)
In-Reply-To: <c8a10777-9da1-461e-0b69-2c1280fa0ee7@linux.vnet.ibm.com>
I work on the perf tool and its bpf support for IBM s390 and came across a
strange issue compiling tools/testing/selftests/bpf/test_verifier.c on s390x.
This is the compile error:
gcc -Wall -O2 -I../../../include/uapi -I../../../lib -I../../../../include/generated
-DHAVE_GENHDR -I../../../include test_verifier.c
/root/linux-devel/tools/testing/selftests/bpf/libbpf.a -lcap -lelf -o
/root/linux-devel/tools/testing/selftests/bpf/test_verifier
In file included from test_verifier.c:63:0:
../../../include/uapi/linux/bpf_perf_event.h:14:17: error: field ‘regs’ has
incomplete type struct pt_regs regs;
This shows up in test case "unpriv: spill/fill of different pointers ldx"
at line 1811.
This issue is located in file /usr/include/linux/bpf_perf_event.h which is a
copy of the linux kernels include/uapi/linux/bpf_perf_event.h.
It contains:
struct bpf_perf_event_data {
struct pt_regs regs;
__u64 sample_period;
};
On s390 struct pt_regs is not exported to user space and does not appear
anywhere in /usr/include.
How about other architectures beside Intel?
As far as I know
1. the struct pt_regs contains only kernel registers, no user space registers?
2. Is part of the kernel API and should not be exported at all?
When I investigated the kernel side of the bpf() system call, the test case ends
up in functions pe_prog_is_valid_access() and pe_prog_convert_ctx_access()
via syscall(bpf)
+--> bpf_prog_load()
+--> find_prog_type() to load eBPF type specific verifiers
| pe_prog_is_valid_access() and pe_prog_convert_ctx_access()
+--> bpf_check() to verify (and modify) the eBPF
+--> check_vfg()
+--> do_check()
+--> check_xadd()
+--> check_mem_access()
+--> check_ctx_access()
+--> env->prog->aux->ops->is_valid_access
which is set to
pe_prog_is_valid_access()
Now this last function expects and verifies struct pt_regs via struct member
offsets which needs a correct struct pt_regs previously setup by user space
eBPF program.
This also requires a correct struct pt_regs in /usr/include/linux/bpf_perf_event.h
(which includes /usr/include/{linux,asm,sym}/ptrace.h
How to achieve this on a platform which does not export struct pt_regs to the
user?
Thanks a lot for your help.
--
Thomas Richter, Dept 3303, IBM LTC Boeblingen Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next parent reply other threads:[~2017-08-02 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c8a10777-9da1-461e-0b69-2c1280fa0ee7@linux.vnet.ibm.com>
2017-08-02 11:22 ` Thomas-Mich Richter [this message]
[not found] ` <CAADnVQKpaF+3EZKMtMBdKLatEQGytqc9YJQQSSFRFQ=7THpvTw@mail.gmail.com>
2017-08-04 15:28 ` Fwd: " Daniel Borkmann
2017-08-08 8:09 ` Thomas-Mich Richter
2017-08-14 12:08 ` Heiko Carstens
2017-08-14 14:39 ` Arnd Bergmann
2017-08-23 5:01 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49c5e39b-a7d9-1e2d-24ec-57852f7d1e51@linux.vnet.ibm.com \
--to=tmricht@linux.vnet.ibm.com \
--cc=ast@kernel.org \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®