From: "André Almeida" <andrealmeid@igalia.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
kernel-dev@igalia.com, "Melissa Wen" <mwen@igalia.com>,
alexander.deucher@amd.com, christian.koenig@amd.com,
"Simon Ser" <contact@emersion.fr>,
"Pekka Paalanen" <ppaalanen@gmail.com>,
daniel@ffwll.ch, "Daniel Stone" <daniel@fooishbar.org>,
"'Marek Olšák'" <maraeo@gmail.com>,
"Dave Airlie" <airlied@gmail.com>,
ville.syrjala@linux.intel.com,
"Xaver Hugl" <xaver.hugl@gmail.com>,
"Joshua Ashton" <joshua@froggi.es>,
"Michel Dänzer" <michel.daenzer@mailbox.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Karol Herbst" <kherbst@redhat.com>,
"Lyude Paul" <lyude@redhat.com>
Subject: Re: [PATCH v6 2/8] drm: Support per-plane async flip configuration
Date: Fri, 14 Jun 2024 16:45:21 -0300 [thread overview]
Message-ID: <49cd9364-d0c9-4900-9b44-d317bde8c668@igalia.com> (raw)
In-Reply-To: <ycgax5ulfcdho2ocrqhzwuvrtwjkwuzi4ghnutl72e5ye3wkxf@ajirwgg7ozwp>
Em 14/06/2024 14:32, Dmitry Baryshkov escreveu:> On Fri, Jun 14, 2024 at
12:35:29PM GMT, André Almeida wrote:
>> Drivers have different capabilities on what plane types they can or
>> cannot perform async flips. Create a plane::async_flip field so each
>> driver can choose which planes they allow doing async flips.
>>
>> Signed-off-by: André Almeida <andrealmeid@igalia.com>
>> ---
>> drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
>> include/drm/drm_plane.h | 5 +++++
>> 2 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_atomic_uapi.c
b/drivers/gpu/drm/drm_atomic_uapi.c
>> index 2e1d9391febe..ed1af3455477 100644
>> --- a/drivers/gpu/drm/drm_atomic_uapi.c
>> +++ b/drivers/gpu/drm/drm_atomic_uapi.c
>> @@ -1079,9 +1079,9 @@ int drm_atomic_set_property(struct
drm_atomic_state *state,
>> break;
>> }
>>
>> - if (async_flip && plane_state->plane->type !=
DRM_PLANE_TYPE_PRIMARY) {
>> + if (async_flip && !plane->async_flip) {
>
> So, after this patch async flips becomes disabled until the driver
> enables that manually. Whether that's desired or not is a separate
> topic, but this definitely should be explicitly mentioned in the commit
> message.
>
You are right, I think I should separate this in the last commit, so we
don't have any regression commits. Thanks for the feedback
next prev parent reply other threads:[~2024-06-14 19:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 15:35 [PATCH v6 0/8] " André Almeida
2024-06-14 15:35 ` [PATCH v6 1/8] drm/atomic: Allow userspace to use explicit sync with atomic async flips André Almeida
2024-06-14 15:35 ` [PATCH v6 2/8] drm: Support per-plane async flip configuration André Almeida
2024-06-14 17:32 ` Dmitry Baryshkov
2024-06-14 19:45 ` André Almeida [this message]
2024-06-14 15:35 ` [PATCH v6 3/8] drm/amdgpu: Enable async flips on the primary plane André Almeida
2024-06-14 15:35 ` [PATCH v6 4/8] drm: atmel-hlcdc: " André Almeida
2024-06-14 15:35 ` [PATCH v6 5/8] drm/i915: " André Almeida
2024-06-14 19:00 ` Rodrigo Vivi
2024-06-14 15:35 ` [PATCH v6 6/8] drm/nouveau: " André Almeida
2024-06-14 15:35 ` [PATCH v6 7/8] drm/vc4: " André Almeida
2024-06-14 15:35 ` [PATCH v6 8/8] drm/amdgpu: Make it possible to async flip overlay planes André Almeida
2024-06-14 17:32 ` [PATCH v6 0/8] drm: Support per-plane async flip configuration Dmitry Baryshkov
2024-06-14 19:37 ` André Almeida
2024-06-19 11:57 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49cd9364-d0c9-4900-9b44-d317bde8c668@igalia.com \
--to=andrealmeid@igalia.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bbrezillon@kernel.org \
--cc=christian.koenig@amd.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=daniel@fooishbar.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joshua@froggi.es \
--cc=kernel-dev@igalia.com \
--cc=kherbst@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maraeo@gmail.com \
--cc=michel.daenzer@mailbox.org \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=nicolas.ferre@microchip.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ppaalanen@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=xaver.hugl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®