Re: [PATCH v4 2/4] media: imagination: e5010: Fix clk never enabled without CONFIG_PM

[Devarsh Thakkar <devarsht@ti.com>]

Hi Brandon,

Thanks for the patch.

On 01/09/26 03:02, Brandon Brnich wrote:
> clk_prepare_enable is not called anywhere unless CONFIG_PM is set. This
> means without CONFIG_PM, the JPEG Encoder will not function properly.
> 
> Add this call during the probe sequence to properly configure the device.
> If video_registration fails after clk is enabled, clk would be left on.
> Make a label to cover this case.
> 
> Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> ---
>   .../media/platform/imagination/e5010-jpeg-enc.c    | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> index d3c11337c815d..e98fcd3fcd9ae 100644
> --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -1099,19 +1099,28 @@ static int e5010_probe(struct platform_device *pdev)
>   		goto fail_after_video_register_device;
>   	}
>   
> -	pm_runtime_enable(dev);
> +	ret = clk_prepare_enable(e5010->clk);
> +	if (ret) {
> +		dev_err_probe(dev, ret, "failed to enable clock\n");
> +		goto fail_after_video_register_device;
> +	}
> +
>   
>   	ret = video_register_device(e5010->vdev, VFL_TYPE_VIDEO, 0);
>   	if (ret) {
>   		dev_err_probe(dev, ret, "failed to register video device\n");
> -		goto fail_after_video_register_device;
> +		goto fail_after_clock_enable;
>   	}
>   
> +	pm_runtime_enable(dev);
> +
>   	v4l2_info(&e5010->v4l2_dev, "Device registered as /dev/video%d\n",
>   		  e5010->vdev->num);
>   
>   	return 0;
>   
> +fail_after_clock_enable:
> +	clk_disable_unprepare(e5010->clk);
>   fail_after_video_register_device:
>   	v4l2_m2m_release(e5010->m2m_dev);
>   fail_after_v4l2_register:
> @@ -1126,6 +1135,7 @@ static void e5010_remove(struct platform_device *pdev)
>   	struct e5010_dev *e5010 = platform_get_drvdata(pdev);
>   
>   	pm_runtime_disable(e5010->dev);
> +	clk_disable_unprepare(e5010->clk);

I think you should only disable if driver was not suspended as you 
already do a clk_disable in suspend path, i think it should be :

         if (!pm_runtime_status_suspended(&pdev->dev)) 

		clk_disable_unprepare(e5010->clk);

Regards
Devarsh
>   	video_unregister_device(e5010->vdev);
>   	v4l2_m2m_release(e5010->m2m_dev);
>   	v4l2_device_unregister(&e5010->v4l2_dev);