From: Joe Perches <joe@perches.com>
To: Julio Faracco <jcfaracco@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stern@rowland.harvard.edu, gregkh@linuxfoundation.org,
axboe@kernel.dk, tglx@linutronix.de, damien.lemoal@wdc.com,
dkadashev@gmail.com, paul.gortmaker@windriver.com,
zhouyanjie@wanyeetech.com, niklas.cassel@wdc.com,
penguin-kernel@i-love.sakura.ne.jp, macro@orcam.me.uk,
caihuoqing@baidu.com
Subject: Re: [PATCH] usb: fixing some clang warnings inside usb host drivers
Date: Sat, 18 Dec 2021 02:49:41 -0800 [thread overview]
Message-ID: <49dbcc338213926850d61faba700241155d04fc1.camel@perches.com> (raw)
In-Reply-To: <20211218042420.28466-1-jcfaracco@gmail.com>
On Sat, 2021-12-18 at 01:24 -0300, Julio Faracco wrote:
> Clang is reporting some issues related variable values not used and
> other issues inside some USB host drivers. This commit removes some
> trashes and adds some strategies to mitigate those warnings.
[]
> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
[]
> @@ -903,7 +903,6 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
> temp = scnprintf(next, size, "complete %ld unlink %ld\n",
> ehci->stats.complete, ehci->stats.unlink);
> size -= temp;
> - next += temp;
> #endif
I think this should line not be removed as it's a code pattern
repeated multiple times above and another entry could be added
below.
next prev parent reply other threads:[~2021-12-18 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 4:24 Julio Faracco
2021-12-18 9:13 ` Greg KH
2021-12-18 10:49 ` Joe Perches [this message]
2021-12-18 18:05 ` Alan Stern
2021-12-19 1:41 ` Tetsuo Handa
2021-12-19 2:50 ` Alan Stern
2021-12-19 7:59 ` Tetsuo Handa
2021-12-19 15:46 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49dbcc338213926850d61faba700241155d04fc1.camel@perches.com \
--to=joe@perches.com \
--cc=axboe@kernel.dk \
--cc=caihuoqing@baidu.com \
--cc=damien.lemoal@wdc.com \
--cc=dkadashev@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jcfaracco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=niklas.cassel@wdc.com \
--cc=paul.gortmaker@windriver.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®