From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: Johannes Berg <johannes@sipsolutions.net>, Tejun Heo <tj@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
"syzkaller-bugs@googlegroups.com"
<syzkaller-bugs@googlegroups.com>,
Hillf Danton <hdanton@sina.com>,
syzbot <syzbot+c56f6371c48cad0420f9@syzkaller.appspotmail.com>
Subject: Re: [syzbot] INFO: task hung in hci_dev_close_sync
Date: Thu, 28 Jul 2022 21:25:50 +0900 [thread overview]
Message-ID: <49e04fb8-e8fe-17d3-0b5f-e8d255010936@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <05280c37163d08ff2d00d71c5454baf651867bd3.camel@sipsolutions.net>
On 2022/05/04 18:24, Johannes Berg wrote:
> On Wed, 2022-05-04 at 05:12 +0000, Tetsuo Handa wrote:
>>
>> This seems to be a question regarding commit 87915adc3f0acdf0 ("workqueue: re-add lockdep dependencies for flushing").
>>>
>>> syzbot should have been able to catch cancel_work_sync() in work context
>>> by checking lockdep_map in __flush_work() for both flush and cancel.
>>>
>>> Hillf
>>>
>>> --- y/kernel/workqueue.c
>>> +++ x/kernel/workqueue.c
>>> @@ -3075,10 +3075,10 @@ static bool __flush_work(struct work_str
>>> if (WARN_ON(!work->func))
>>> return false;
>>>
>>> - if (!from_cancel) {
>>> + //if (!from_cancel) {
>>>
>
> I think this is explained in commit d6e89786bed9 ("workqueue: skip
> lockdep wq dependency in cancel_work_sync()")
I couldn't agree on that reasoning, and I sent
https://lkml.kernel.org/r/21b9c1ac-64b7-7f4b-1e62-bf2f021fffcd@I-love.SAKURA.ne.jp .
next prev parent reply other threads:[~2022-07-28 12:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220504044800.4966-1-hdanton@sina.com>
2022-05-04 5:12 ` Tetsuo Handa
2022-05-04 9:24 ` Johannes Berg
2022-07-28 12:25 ` Tetsuo Handa [this message]
[not found] <20220529093522.4155-1-hdanton@sina.com>
2022-05-29 9:58 ` syzbot
2022-05-03 16:59 syzbot
2022-05-29 5:55 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e04fb8-e8fe-17d3-0b5f-e8d255010936@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=dvyukov@google.com \
--cc=hdanton@sina.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+c56f6371c48cad0420f9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®