mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Liang Li <liali@redhat.com>
Cc: j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	Paolo Abeni <pabeni@redhat.com>,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	john.fastabend@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Hangbin Liu <haliu@redhat.com>,
	"Toppins, Jonathan" <jtoppins@redhat.com>
Subject: Re: [Question] About bonding offload
Date: Tue, 11 Apr 2023 04:19:02 +0200	[thread overview]
Message-ID: <49e0cf25-331b-4d26-8d9a-66434e7a270e@lunn.ch> (raw)
In-Reply-To: <CAKVySpzU_23Z6Gu1N=z0DRm+sUQDjyiyUc18r4rJ_YQ+YELuFg@mail.gmail.com>

On Tue, Apr 11, 2023 at 09:47:14AM +0800, Liang Li wrote:
> Hi Everyone,
> 
> I'm a redhat network-qe and am testing bonding offload. e.g. gso,tso,gro,lro.
> I got two questions during my testing.
> 
> 1. The tcp performance has no difference when bonding GRO is on versus off.
> When testing with bonding, I always get ~890 Mbits/sec bandwidth no
> matter whether GRO is on.
> When testing with a physical NIC instead of bonding on the same
> machine, with GRO off, I get 464 Mbits/sec bandwidth, with GRO on, I
> get  897 Mbits/sec bandwidth.
> So looks like the GRO can't be turned off on bonding?
> 
> I used iperf3 to test performance.
> And I limited iperf3 process cpu usage during my testing to simulate a
> cpu bottleneck.
> Otherwise it's difficult to see bandwidth differences when offload is
> on versus off.
> 
> I reported a bz for this: https://bugzilla.redhat.com/show_bug.cgi?id=2183434
> 
> 2.  Should bonding propagate offload configuration to slaves?
> For now, only "ethtool -K bond0 lro off" can be propagated to slaves,
> others can't be propagated to slaves, e.g.
>   ethtool -K bond0 tso on/off
>   ethtool -K bond0 gso on/off
>   ethtool -K bond0 gro on/off
>   ethtool -K bond0 lro on
> All above configurations can't be propagated to bonding slaves.
> 
> I reports a bz for this: https://bugzilla.redhat.com/show_bug.cgi?id=2183777
> 
> I am using the RHEL with kernel 4.18.0-481.el8.x86_64.
 
Hi Liang

Can you reproduce these issues with a modern kernel? net-next, or 6.3?

The normal process for issues like this is to investigate with the
latest kernel, and then backport fixes to old stable kernels.

       Andrew

  reply	other threads:[~2023-04-11  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11  1:47 Liang Li
2023-04-11  2:19 ` Andrew Lunn [this message]
2023-04-11  4:58 ` Jay Vosburgh
2023-04-11  5:15   ` Liang Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49e0cf25-331b-4d26-8d9a-66434e7a270e@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andy@greyhouse.net \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=haliu@redhat.com \
    --cc=hawk@kernel.org \
    --cc=j.vosburgh@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jtoppins@redhat.com \
    --cc=kuba@kernel.org \
    --cc=liali@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®