From: Joe Perches <joe@perches.com>
To: Antonio Borneo <borneo.antonio@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] checkpatch: replace magic value for TAB size
Date: Wed, 08 May 2019 10:02:42 -0700 [thread overview]
Message-ID: <49e0fb2cd3b0a80848f67212167fdbab4b5b8a97.camel@perches.com> (raw)
In-Reply-To: <CAAj6DX3LahQK_t0paVzcTfTsavANXnatgc_vX_1VLPJ9RhsdHQ@mail.gmail.com>
On Wed, 2019-05-08 at 17:32 +0200, Antonio Borneo wrote:
> On Wed, May 8, 2019 at 4:52 PM Joe Perches <joe@perches.com> wrote:
> ...
> > > In these cases the script will be probably modified and adapted,
> > > so there is no need (at least for the moment) to expose this
> > > setting on the script's command line.
> >
> > Disagree. Probably getter to add a --tabsize=<foo> option now.
>
> Ok, will send a V2 including the command line option.
> Exposing TAB size, makes the option name relevant; should I keep
> "--tabsize" or is "--tab-stop" more appropriate?
--tabsize is probably more appropriate as tab stops are not
always a multiple of a single number.
Unless you really want to get funky and support something like
--tab-stops=7,13,17,...
I don't suggest that.
next prev parent reply other threads:[~2019-05-08 17:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 12:27 [PATCH 1/4] checkpatch: fix multiple const * types Antonio Borneo
2019-05-08 12:27 ` [PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS Antonio Borneo
2019-05-08 14:19 ` Joe Perches
2019-05-08 12:27 ` [PATCH 3/4] checkpatch: fix minor typo and mixed space+tab in indentation Antonio Borneo
2020-01-22 16:38 ` [PATCH V2] " Antonio Borneo
2020-01-22 17:26 ` Joe Perches
2019-05-08 12:27 ` [PATCH 4/4] checkpatch: replace magic value for TAB size Antonio Borneo
2019-05-08 14:52 ` Joe Perches
2019-05-08 15:32 ` Antonio Borneo
2019-05-08 17:02 ` Joe Perches [this message]
2019-05-08 14:51 ` [PATCH 1/4] checkpatch: fix multiple const * types Joe Perches
2019-05-08 15:26 ` Antonio Borneo
2020-01-22 16:38 ` [PATCH V3] " Antonio Borneo
2019-05-08 17:43 ` [PATCH v2] " Antonio Borneo
2019-09-04 9:37 ` Antonio Borneo
2019-05-08 17:43 [PATCH v2] checkpatch: add command-line option for TAB size Antonio Borneo
2019-05-08 17:56 ` Joe Perches
2019-05-08 18:19 ` Antonio Borneo
2019-05-08 18:36 ` [PATCH v3] " Antonio Borneo
2019-05-08 21:14 ` [PATCH v2] " Elliott, Robert (Servers)
2019-05-08 21:59 ` Joe Perches
2019-05-08 22:03 ` Antonio Borneo
2019-05-09 7:21 [PATCH v4] " Antonio Borneo
2019-05-09 8:03 ` Joe Perches
2019-05-09 9:26 ` Antonio Borneo
2019-05-09 9:39 ` [PATCH v5] " Antonio Borneo
2020-01-22 16:38 ` [PATCH V6] " Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e0fb2cd3b0a80848f67212167fdbab4b5b8a97.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=borneo.antonio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®