From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936081AbeCHRvm (ORCPT ); Thu, 8 Mar 2018 12:51:42 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34494 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936058AbeCHRvi (ORCPT ); Thu, 8 Mar 2018 12:51:38 -0500 X-Google-Smtp-Source: AG47ELt7dLBQvVQgPS0DQoU4k7y5Um6wC5V9NAaUpQzXk4aLjTzBrexZSZ53DH8XlZ9yWeNA1T8Lkw== Subject: Re: [PATCH 1/2] backlight: Add RAVE SP backlight driver To: Andrey Smirnov Cc: Lee Jones , Jingoo Han , linux-kernel , Chris Healy , Lucas Stach , Aleksander Morgado References: <20180307024011.25033-1-andrew.smirnov@gmail.com> From: Daniel Thompson Message-ID: <49e36db6-6f53-348c-d758-7c20e5a72e9d@linaro.org> Date: Thu, 8 Mar 2018 17:51:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/18 17:29, Andrey Smirnov wrote: > On Thu, Mar 8, 2018 at 8:58 AM, Daniel Thompson > wrote: >> On 07/03/18 02:40, Andrey Smirnov wrote: >>> >>> This driver provides access to RAVE SP backlight control >>> functionality. >>> >>> Cc: Lee Jones >>> Cc: Daniel Thompson >>> Cc: Jingoo Han >>> Cc: linux-kernel@vger.kernel.org >>> Cc: Chris Healy >>> Cc: Lucas Stach >>> Cc: Aleksander Morgado >>> Signed-off-by: Andrey Smirnov >>> --- >>> drivers/video/backlight/Kconfig | 6 +++ >>> drivers/video/backlight/Makefile | 1 + >>> drivers/video/backlight/rave-sp-backlight.c | 82 >>> +++++++++++++++++++++++++++++ >>> include/linux/mfd/rave-sp.h | 1 + >>> 4 files changed, 90 insertions(+) >>> create mode 100644 drivers/video/backlight/rave-sp-backlight.c >>> >>> diff --git a/drivers/video/backlight/Kconfig >>> b/drivers/video/backlight/Kconfig >>> index 4e1d2ad50ba1..5d2d0d7e8100 100644 >>> --- a/drivers/video/backlight/Kconfig >>> +++ b/drivers/video/backlight/Kconfig >>> @@ -467,6 +467,12 @@ config BACKLIGHT_ARCXCNN >>> If you have an ARCxCnnnn family backlight say Y to enable >>> the backlight driver. >>> +config BACKLIGHT_RAVE_SP >>> + tristate "RAVE SP Backlight driver" >>> + depends on RAVE_SP_CORE >>> + help >>> + Support for backlight control on RAVE SP device. >>> + >>> endif # BACKLIGHT_CLASS_DEVICE >>> endif # BACKLIGHT_LCD_SUPPORT >>> diff --git a/drivers/video/backlight/Makefile >>> b/drivers/video/backlight/Makefile >>> index 5e28f01c8391..19da71d518bf 100644 >>> --- a/drivers/video/backlight/Makefile >>> +++ b/drivers/video/backlight/Makefile >>> @@ -57,3 +57,4 @@ obj-$(CONFIG_BACKLIGHT_TOSA) += tosa_bl.o >>> obj-$(CONFIG_BACKLIGHT_TPS65217) += tps65217_bl.o >>> obj-$(CONFIG_BACKLIGHT_WM831X) += wm831x_bl.o >>> obj-$(CONFIG_BACKLIGHT_ARCXCNN) += arcxcnn_bl.o >>> +obj-$(CONFIG_BACKLIGHT_RAVE_SP) += rave-sp-backlight.o >>> diff --git a/drivers/video/backlight/rave-sp-backlight.c >>> b/drivers/video/backlight/rave-sp-backlight.c >>> new file mode 100644 >>> index 000000000000..62836ba561db >>> --- /dev/null >>> +++ b/drivers/video/backlight/rave-sp-backlight.c >>> @@ -0,0 +1,82 @@ >>> +// SPDX-License-Identifier: GPL-2.0+ >>> + >>> +/* >>> + * LCD Backlight driver for RAVE SP >>> + * >>> + * Copyright (C) 2018 Zodiac Inflight Innovations >>> + * >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#define RAVE_SP_BACKLIGHT_LCD_EN BIT(7) >>> + >>> +static int rave_sp_backlight_update_status(struct backlight_device *bd) >>> +{ >>> + const struct backlight_properties *p = &bd->props; >>> + const u8 intensity = >>> + (p->power == FB_BLANK_UNBLANK) ? p->brightness : 0; >>> + struct rave_sp *sp = dev_get_drvdata(&bd->dev); >>> + u8 cmd[] = { >>> + [0] = RAVE_SP_CMD_SET_BACKLIGHT, >>> + [1] = 0, >>> + [2] = intensity ? RAVE_SP_BACKLIGHT_LCD_EN | intensity : >>> 0, >>> + [3] = 0, >>> + [4] = 0, >>> + }; >>> + >>> + return rave_sp_exec(sp, cmd, sizeof(cmd), NULL, 0); >>> +} >>> + >>> +static const struct backlight_ops rave_sp_backlight_ops = { >>> + .options = BL_CORE_SUSPENDRESUME, >>> + .update_status = rave_sp_backlight_update_status, >>> +}; >>> + >>> +static struct backlight_properties rave_sp_backlight_props = { >>> + .type = BACKLIGHT_FIRMWARE, >> >> >> I would have thought BACKLIGHT_PLATFORM would be more suitable here. >> BACKLIGHT_FIRMWARE is used for things like the ACPI backlight driver. >> >> Why did you select this one? >> > > Good point and I don't think I have any justification to choose > FIRMWARE over PLATFORM, will fix in v2. Thanks. With that fixed: Acked-by: Daniel Thompson Daniel.