From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hermes Zhang <chenhuiz@axis.com>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andrew Davis <afd@ti.com>
Cc: kernel@axis.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: power: supply: bq256xx: Add ts-ignore property
Date: Thu, 9 Mar 2023 11:12:43 +0100 [thread overview]
Message-ID: <49e67fb3-4ef9-5d50-c3e8-3c7857145bbc@linaro.org> (raw)
In-Reply-To: <20230309023926.38682-1-chenhuiz@axis.com>
On 09/03/2023 03:39, Hermes Zhang wrote:
> Add a new property: ts-ignore to allow user to enable the TS_IGNORE flag
> in chip. Ignore TS pin will allow user to control the charging
> parameters instead of the default JEITA profile in chip.
You miss users of it.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
> Documentation/devicetree/bindings/power/supply/bq256xx.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> index 82f382a7ffb3..74fd48f4bec5 100644
> --- a/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/bq256xx.yaml
> @@ -68,6 +68,12 @@ properties:
> Interrupt sends an active low, 256 μs pulse to host to report the charger
> device status and faults.
>
> + ts-ignore:
Missing vendor prefix... is this generic property? ts-ignore is very
cryptic. You should describe here rather desired system characteristic.
Why anyone would need to use it per-board level?
> + type: boolean
> + description: |
> + If this property is set, the TS_IGNORE flag will be set to 1 which means
> + will not apply JEITA profile during the charging.> +
> required:
> - compatible
> - reg
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-09 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 2:39 Hermes Zhang
2023-03-09 10:12 ` Krzysztof Kozlowski [this message]
2023-03-10 3:48 ` Hermes Zhang
2023-03-10 8:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e67fb3-4ef9-5d50-c3e8-3c7857145bbc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®