From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0F61C6B4 for ; Thu, 16 Oct 2025 01:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760579868; cv=none; b=Pc19RDAL5abCs1HlBU/STEGdH9gchcx2w+c+YjnP4nBj2ctQ1Fj1Lc8VDmNoFVWNmJAB0oC0GsdWhPu0IDGqjE56AE97+vn+cPzNMBfqVn4hPs0tfeNCSn6AU9z96cL3m4jbZLZLMeTRB9XgxY02O5XhrEnOrrec5HU3Fgj6w/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760579868; c=relaxed/simple; bh=IlqfZYOkclJozio66DYG7OYgRXYQlBuKL8VU6g3WR5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rW10c9Z+8t054M3mQ3A6HiP1BJyowy8YEs8+gZd7WspIKtlTFde68Ln9qYNw/6JMwattKdMUkC26cznh8o3CL+w8S1kZIAga9XR4qOoecarSkYHVj6BmoG/NoApsguyv7VqnyzPETPIMsjXQ4vCyze1a3rZszwySb613eAFdW0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hd8BpW63; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hd8BpW63" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59FJwax0014770 for ; Thu, 16 Oct 2025 01:57:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iFKFkzfdP4tXFi/0ymgZNK4f9HBW4SXK15XqkMQS4eg=; b=Hd8BpW63ejTcRndk ioLHaXxOS69bC50fLat0MRB4ixQS80B43f6oTy2U43UJD4G/Vu1+gKLNRe4qzteP zu9sp8LdFQlVH/2PddvqoIbLD12IphHiLeZsB81fXDSNNyS1sN+OGRwbz8k6gD8W gQP/VnOsmH3IUdvOLXT4AxDgFoFnERYJqWgf4B/vN9+fBgk8ikzCD4lCiSf5uK2A TG70lVtpBoBNjtSJJgY0l7JwRbO40/DvSKLyEA2faBv4bsx/NeKYavAP/US+jr2z UyA4mE98TZUXKD0Qp6j1TBCMFBK+si1WjVAAWTy+gvQ7plOWGwTt+tnQy8rw2tg0 4lulvw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49qfbj6j0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 16 Oct 2025 01:57:45 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b63038a6350so1043827a12.0 for ; Wed, 15 Oct 2025 18:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760579864; x=1761184664; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iFKFkzfdP4tXFi/0ymgZNK4f9HBW4SXK15XqkMQS4eg=; b=u3Jd+Wr+2ECu4w+lt7ryAVhFSURRYLpukG9VAcClnpFjVNnkBJmuFBCjhx6ZLQx/lU rK+z/6hFFx5iojoGt3gB4u2zeQGf25ZVfl78qGcPui9uvZouQ00LFH3lvbSH/VVfr4Eu nCpjaoJz0YHuI55wejtZEUFo0Av62gcEuuHMwoouVzkx7H9/u3mrEAbO3REAVxo9anoc rhdoOikmHBtREjCCf95PHQqXS4dY5rMSF67xLwAFRfL5lXF/ntmgrbX+NuYxcaUO7Hpr 7KfBsWAlHnXrFq6KCCd6+/A1JDfOxzX97oiOlmkL4Wy15q2NUhLw89vQUglr1VsuFRNO RFmA== X-Forwarded-Encrypted: i=1; AJvYcCUsXrGYl+hPNnR+UXGgHvvHvPeN1Xtfxxn1i9YcMe9rZAjLbCOLcG3gHkmwR8qdWetmEnexN58Le3xbda0=@vger.kernel.org X-Gm-Message-State: AOJu0YzvNH2vBdgC+mVWi0MQOsengurXiLQQpwhxzDwvErHk4D782kNv fLbuk3gwSbjlLVlo2RIHZmM7kRbURrnotzkiaLRSWW2CEydFICRIWAPXj3D5O8peCYrN5kB+A/l lGcQZJfs06qYjeBo/NhF6nMenzh5jX902EIxM/COjsD32+P1iNnKIaR8rLi77I4ZsZ28= X-Gm-Gg: ASbGncuYlneqdRN0vl+AKW+3r/CaSRudF9v9SyhLBUR51lPM477FriQWQIJrUvPoJBg TKU4xIIAUwc+VsviM+KmxtDK/DBQy109PxJK7OlQP9oeLt6UQy34Aliu60JjR80YUZxqaZDHslO FUfoH9aAcapJIgfeBXnaLcfbivVYPBv4mpenEslR9vmOrNkV737dl6FsSmbkhRiiWMnZY8ANyk7 WhH/K9otjIYjU9MLhJcZccN14+SW/fVPeSsol60etQkFttv+jiDkuVQir8G4S0migcF5p3GCCCL lFm0g7ScvfY8NZywtpGJ/YS9wOGeGfA3m7NjnkmC5nYDoeSr9gL9Q5E8u/RVD/YpfJ7b6fIJ/Aj LvFgaZnQf/kIVNIhAwCC+DL8+w435MoHHK1BcUcoHdDktsuub4yJXO6Lo6Lcxp62G/IDWJQ== X-Received: by 2002:a17:903:24f:b0:279:373b:407f with SMTP id d9443c01a7336-290918cbe15mr26360975ad.5.1760579864420; Wed, 15 Oct 2025 18:57:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnvLDZlV6wBkfvT/qOi99EG5lDHNY9fLIFApqLJJBI0OqJ12Q8JQrRLN+J+RuPFy68M+KAyg== X-Received: by 2002:a17:903:24f:b0:279:373b:407f with SMTP id d9443c01a7336-290918cbe15mr26360465ad.5.1760579863918; Wed, 15 Oct 2025 18:57:43 -0700 (PDT) Received: from [10.133.33.56] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29099aa32c4sm10285605ad.79.2025.10.15.18.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 18:57:43 -0700 (PDT) Message-ID: <49eaf7ec-ac71-4bf3-9a4e-25fa633d815e@oss.qualcomm.com> Date: Thu, 16 Oct 2025 09:56:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible To: Vladimir Zapolskiy , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bryan O'Donoghue Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-1-f5745ba2dff9@oss.qualcomm.com> Content-Language: en-US From: Hangxiang Ma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDExMDAxOCBTYWx0ZWRfX9LcaxX9SDIaT Jq2iCrr/eUF4Cc0/qgoyIElE854I2fMDFjCn50Tw7Bm2nGAChxjEMWeWhc+ODU4Ola92Jc+Em6t NJ2cft6MPV8IRkpTqnWRZofMB/h6slfvee0zU+VdEagnqRYb4aSGnFLh+nCI6JGV8OQzJwlLRWO s1sVwNKQbgFTVJm4yqXHYcRpDgnxibmmMSiXNALgh05L+K1ngBET5qv2yOxqG+cnb3V8Nem4weL QCPC5TrNss9Y++Ys56ZGFJgYZXkKMrQi386pHzB8FFvvBa59rDY7Iz64p57taMNUZB16jZSkjJe 4Glbvj9qv5VSN/kNdnu1FEcUIAPJygje5WVo3fL70LrrNTM5e8aaeqImWf4JBDRPLHvkL8mgSKY I2o0FLfJQ3LSpARUIa+c1ihBBWkzpg== X-Proofpoint-ORIG-GUID: ayNJjmgRRar6MIxevrCDgFVPvx0Ejnek X-Authority-Analysis: v=2.4 cv=bodBxUai c=1 sm=1 tr=0 ts=68f05119 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=QmC_9Nfu3_VqyKKViBAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: ayNJjmgRRar6MIxevrCDgFVPvx0Ejnek X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-15_07,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510110018 On 10/16/2025 3:30 AM, Vladimir Zapolskiy wrote: > On 10/15/25 05:56, Hangxiang Ma wrote: >> Add Kaanapali compatible consistent with CAMSS CCI interfaces. The list >> of clocks for Kaanapali requires its own compat string 'cam_top_ahb', >> aggregated into 'qcom,qcm2290-cci' node. >> >> Signed-off-by: Hangxiang Ma >> --- >>   Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 +++++- >>   1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> index 9bc99d736343..0140c423f6f4 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> @@ -25,6 +25,7 @@ properties: >>         - items: >>             - enum: >> +              - qcom,kaanapali-cci >>                 - qcom,qcm2290-cci >>                 - qcom,sa8775p-cci >>                 - qcom,sc7280-cci >> @@ -128,6 +129,7 @@ allOf: >>           compatible: >>             contains: >>               enum: >> +              - qcom,kaanapali-cci >>                 - qcom,qcm2290-cci >>       then: >>         properties: >> @@ -136,7 +138,9 @@ allOf: >>             maxItems: 2 >>           clock-names: >>             items: >> -            - const: ahb >> +            - enum: >> +                - ahb >> +                - cam_top_ahb > > Why is not to give the clock "ahb" name like on QCM2290? > > On QCM2290 the macro in front of the vlaue is GCC_CAMSS_TOP_AHB_CLK, > and name "ahb" is good for both, I believe. > >>               - const: cci >>     - if: >> > On Kaanapali the macro has been changed to CAM_CC_CAM_TOP_AHB_CLK. GCC clock domain doesn't manage the AHB clock but CAMCC does. I think it's better to create a new and more complete clock name to denote the differences between them. --- Hangxiang