mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Kim Phillips <kim.phillips@amd.com>,
	Ashish Kalra <ashish.kalra@amd.com>,
	John Allen <john.allen@amd.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Liam Merwick <liam.merwick@oracle.com>
Subject: Re: [PATCH v2] crypto: ccp - Fix null pointer dereference in __sev_snp_shutdown_locked
Date: Tue, 4 Jun 2024 16:36:49 -0500	[thread overview]
Message-ID: <49ef4f0a-683b-ca2a-20a9-65820f8c5e37@amd.com> (raw)
In-Reply-To: <20240604174739.175288-1-kim.phillips@amd.com>

On 6/4/24 12:47, Kim Phillips wrote:
> Fix a null pointer dereference induced by DEBUG_TEST_DRIVER_REMOVE.
> Return from __sev_snp_shutdown_locked() if the psp_device or the
> sev_device structs are not initialized. Without the fix, the driver will
> produce the following splat:
> 

> 
> Fixes: 1ca5614b84ee ("crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP")
> Cc: stable@vger.kernel.org
> Signed-off-by: Kim Phillips <kim.phillips@amd.com>
> Reviewed-by: Liam Merwick <liam.merwick@oracle.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: John Allen <john.allen@amd.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
> v2:
>   - Correct the Fixes tag (Tom L.)
>   - Remove log timestamps, elaborate commit text (John Allen)
>   - Add Reviews-by.
> 
> v1:
>   - https://lore.kernel.org/linux-crypto/20240603151212.18342-1-kim.phillips@amd.com/
> 
>   drivers/crypto/ccp/sev-dev.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 

  reply	other threads:[~2024-06-04 21:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-04 17:47 Kim Phillips
2024-06-04 21:36 ` Tom Lendacky [this message]
2024-06-16  5:56 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ef4f0a-683b-ca2a-20a9-65820f8c5e37@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=ashish.kalra@amd.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=john.allen@amd.com \
    --cc=kim.phillips@amd.com \
    --cc=liam.merwick@oracle.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®