From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26626C433DF for ; Wed, 12 Aug 2020 16:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F383F2076B for ; Wed, 12 Aug 2020 16:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgHLQRv (ORCPT ); Wed, 12 Aug 2020 12:17:51 -0400 Received: from smtprelay0117.hostedemail.com ([216.40.44.117]:53540 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726456AbgHLQRv (ORCPT ); Wed, 12 Aug 2020 12:17:51 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 473701802E60D; Wed, 12 Aug 2020 16:17:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: play11_200348126fec X-Filterd-Recvd-Size: 2835 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Wed, 12 Aug 2020 16:17:48 +0000 (UTC) Message-ID: <49f9d3c8dc8882e36bb8785ac9d6b75e5f35d77b.camel@perches.com> Subject: Re: [PATCH 10/44] staging: spmi: hisi-spmi-controller: do some code cleanups From: Joe Perches To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Jonathan Cameron Date: Wed, 12 Aug 2020 09:17:47 -0700 In-Reply-To: <49a517017f1efbfc97cb0e88f151dc2844d54351.1597247164.git.mchehab+huawei@kernel.org> References: <49a517017f1efbfc97cb0e88f151dc2844d54351.1597247164.git.mchehab+huawei@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-08-12 at 17:56 +0200, Mauro Carvalho Chehab wrote: > There are several minor things that can be cleanup in > order to make this driver more prepared for leaving staging. trivial style notes: > diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c b/drivers/staging/hikey9xx/hisi-spmi-controller.c [] > @@ -106,14 +83,13 @@ static int spmi_controller_wait_for_done(struct device *dev, > struct spmi_controller_dev *ctrl_dev, > void __iomem *base, u8 sid, u16 addr) > { > - u32 status = 0; > u32 timeout = SPMI_CONTROLLER_TIMEOUT_US; > - u32 offset; > + u32 status, offset; > > offset = SPMI_APB_SPMI_STATUS_BASE_ADDR; > offset += SPMI_CHANNEL_OFFSET * ctrl_dev->channel + SPMI_SLAVE_OFFSET * sid; > > - while (timeout--) { > + do { > status = readl(base + offset); > > if (status & SPMI_APB_TRANS_DONE) { > @@ -126,21 +102,21 @@ static int spmi_controller_wait_for_done(struct device *dev, > return 0; > } > udelay(1); > - } > + } while(timeout--); Odd spacing. Two spaces after close brace, none before open parenthesis. > @@ -237,14 +217,13 @@ static int spmi_write_cmd(struct spmi_controller *ctrl, [] > - i = 0; > - do { > + for (i = 0; bc > i * SPMI_PER_DATAREG_BYTE; i++) { > data = 0; > if ((bc - i * SPMI_PER_DATAREG_BYTE) >> 2) { > memcpy(&data, buf, sizeof(data)); > @@ -256,22 +235,22 @@ static int spmi_write_cmd(struct spmi_controller *ctrl, > > writel((u32)cpu_to_be32(data), > spmi_controller->base + chnl_ofst + SPMI_APB_SPMI_WDATA0_BASE_ADDR + SPMI_PER_DATAREG_BYTE * i); > - i++; > - } while (bc > i * SPMI_PER_DATAREG_BYTE); > + }; Unnecessary semicolon after for loop close brace.