From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Andrew Davis <afd@ti.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm: omapdrm: Improve check for contiguous buffers
Date: Fri, 9 Sep 2022 16:08:46 +0300 [thread overview]
Message-ID: <49fba94f-c3b3-d131-2c53-5563675400be@ideasonboard.com> (raw)
In-Reply-To: <20220825162609.14076-1-afd@ti.com>
On 25/08/2022 19:26, Andrew Davis wrote:
> While a scatter-gather table having only 1 entry does imply it is
> contiguous, it is a logic error to assume the inverse. Tables can have
> more than 1 entry and still be contiguous. Use a proper check here.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Changes from v1:
> - Sent correct version of patch :)
Looks fine to me. But where do you need this? Are contiguous buffers
with multiple sgt entries handled correctly elsewhere in the driver,
i.e. do they work? =)
Tomi
prev parent reply other threads:[~2022-09-09 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 16:26 Andrew Davis
2022-09-09 13:08 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49fba94f-c3b3-d131-2c53-5563675400be@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=afd@ti.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®