mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Peter Rosin <peda@axentia.se>,
	Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Josh Wu <rainyfeeling@outlook.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Eugen Hristev <eugen.hristev@microchip.com>
Subject: Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma
Date: Mon, 28 May 2018 18:09:15 +0200	[thread overview]
Message-ID: <49ff8830-eb23-4ea8-0247-0f4fd783afb6@microchip.com> (raw)
In-Reply-To: <db31aac0-6b59-8835-2181-635670e7f176@axentia.se>

On 28/05/2018 at 17:52, Peter Rosin wrote:
> On 2018-05-28 16:27, Boris Brezillon wrote:

[..]

>> Could it just be that you're reaching the DDR bus limit. As I said
>> previously, when you go through the CPU, and assuming you're consuming
>> the data directly, you have:
>>
>> 1/ NFC SRAM -> CPU
>> 2/ CPU -> L1 data cache --write-back--> DRAM
>> 3/ L1-cache -> CPU
>>
>> While, if you use DMA you get:
>>
>> 1/ NFC SRAM -> DRAM
>> 2/ SDRAM -> L1 data cache -> CPU
>>
>> So, if you're approaching the limit of (LP)DDR bandwidth, using the CPU
>> might make things a bit better. Still, if the limitation really comes
>> from the DDR bus, my opinion is that you should maybe use a smaller
>> resolution or use a more compact pixel format (RGB565?).
> 
> The issue is still there if I use a CLUT mode instead of rgb565, which is
> what I normally use (and what I would like to use, CLUT is just alien and
> a pain these days).
> 
> The panels we are using only supports one resolution (each), but the issue
> is there with both 1920x1080@16bpp and 1024x768@8bpp (~60Hz).
> 
>> Did you calculate how much of the bandwidth is taken by the HLCDC
>> block and compared it to the max (LP)DDR bandwidth?
> 
> I did, but don't remember the exact details. There is some room even for
> 1920x1080@16bpp, but not oceans of it. We were a bit uncertain if 16bpp
> would be possible, and in fact that was the reason I worked on CLUT
> support for atmel-hlcdc last year. But since the problem persists with
> much less memory pressure as well, I don't think that's it either.

Just jumping in the conversation with another perspective (maybe already 
tried actually).

Can you try to make all that you can to maximize the blanking period of 
your screen (some are more tolerant than others according to that). By 
doing so, you would allow the LCD FIFO to recover better after each 
line. You might loose some columns on the side of your display but it 
would give us a good idea of how far we are from getting rid of those 
annoying LCD reset glitches (that are due to underruns on LCD FIFO).

> Admittedly I have not tested these AHB matrix tricks with a smaller
> panel (it would take a bit of work to arrange for those tests), but the
> issue was there when I last tried (using defaults).

If what I said earlier has an impact, reducing the panel size will also 
make a difference. But the question is how small is "smaller" ;-)

Best regards,
-- 
Nicolas Ferre

  parent reply	other threads:[~2018-05-28 16:11 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 13:10 Peter Rosin
2018-03-29 13:33 ` Boris Brezillon
2018-03-29 13:37   ` Peter Rosin
2018-03-29 13:44     ` Boris Brezillon
2018-03-29 14:27       ` Peter Rosin
2018-03-30 21:43         ` Peter Rosin
2018-04-02 12:22         ` Boris Brezillon
2018-04-02 17:59           ` Peter Rosin
2018-04-02 19:28             ` Boris Brezillon
2018-04-02 20:20               ` Boris Brezillon
2018-04-02 20:32                 ` Boris Brezillon
2018-04-03  6:11                 ` Peter Rosin
2018-04-03  7:18                   ` Boris Brezillon
2018-04-11 14:44                     ` Peter Rosin
2018-04-11 14:59                       ` Boris Brezillon
2018-04-11 15:10                         ` Peter Rosin
2018-04-11 15:34                           ` Boris Brezillon
2018-04-11 15:34                       ` Nicolas Ferre
2018-04-12  7:18                         ` Peter Rosin
2018-05-22 18:03                         ` Peter Rosin
2018-05-23 10:42                           ` Boris Brezillon
2018-05-25 14:51                         ` Tudor Ambarus
2018-05-26 17:40                           ` Peter Rosin
2018-05-27  9:18                           ` Peter Rosin
2018-05-27 22:11                             ` Peter Rosin
2018-05-28 10:10                               ` Peter Rosin
2018-05-28 14:27                                 ` Boris Brezillon
2018-05-28 15:52                                   ` Peter Rosin
2018-05-28 16:09                                     ` Boris Brezillon
2018-05-28 16:09                                     ` Nicolas Ferre [this message]
2018-05-29  6:30                                 ` Eugen Hristev
2018-05-29  7:10                                   ` Peter Rosin
2018-05-29  7:25                                     ` Eugen Hristev
2018-05-29 14:49                                   ` Boris Brezillon
2018-05-29 15:01                                     ` Eugen Hristev
2018-05-29 15:15                                       ` Boris Brezillon
2018-05-29 15:21                                         ` Eugen Hristev
2018-05-29 15:46                                           ` Boris Brezillon
2018-05-29 17:57                                             ` Boris Brezillon
2018-05-29 21:37                                               ` Peter Rosin
2018-06-04 15:46                                 ` Tudor Ambarus
2018-06-04 16:03                                   ` Boris Brezillon
2018-04-03  6:51                 ` Peter Rosin
2018-04-03  7:15                   ` Boris Brezillon
2018-04-03  7:32                     ` Boris Brezillon
2018-04-03  8:14                     ` Peter Rosin
2018-04-03  8:30                       ` Boris Brezillon
2018-04-02 20:23               ` Peter Rosin
2018-04-02 20:35                 ` Boris Brezillon
2018-04-03  7:18                 ` Alexandre Belloni
2018-04-03  8:37                   ` Peter Rosin
2018-03-29 14:20 ` Nicolas Ferre
2018-03-29 14:23   ` Peter Rosin
2018-03-29 14:29   ` Boris Brezillon
2018-06-18  8:39 ` Boris Brezillon
2018-06-18 14:00   ` Miquel Raynal
2018-06-25 12:31   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ff8830-eb23-4ea8-0247-0f4fd783afb6@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=eugen.hristev@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=marek.vasut@gmail.com \
    --cc=peda@axentia.se \
    --cc=rainyfeeling@outlook.com \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome