From: "Jan Beulich" <jbeulich@novell.com>
To: <ilw@linux.intel.com>
Cc: <reinette.chatre@intel.com>, <linville@tuxdriver.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] iwl3945: fix ia64/ppc build
Date: Tue, 05 May 2009 13:51:08 +0100 [thread overview]
Message-ID: <4A00525C.76EA.0078.0@novell.com> (raw)
Exporting static and non-static symbols in the same compilation unit
results, on some architectures, in section mismatch errors from the
compiler. Since exporting static symbols is bogus altogether, simply
remove the offending export. Once at it, also remove the other export
commit df833b1d73680f9f9dc72cbc3215edbbc6ab740d pointlessly added.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: John W. Linville <linville@tuxdriver.com>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.30-rc4/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-04-30 09:42:55.000000000 +0200
+++ 2.6.30-rc4-iwl3945-build/drivers/net/wireless/iwlwifi/iwl3945-base.c 2009-05-05 14:25:43.000000000 +0200
@@ -1694,7 +1694,6 @@ void iwl3945_rx_queue_reset(struct iwl_p
rxq->free_count = 0;
spin_unlock_irqrestore(&rxq->lock, flags);
}
-EXPORT_SYMBOL(iwl3945_rx_queue_reset);
/*
* this should be called while priv->lock is locked
@@ -1745,7 +1744,6 @@ static void iwl3945_rx_queue_free(struct
rxq->bd = NULL;
rxq->rb_stts = NULL;
}
-EXPORT_SYMBOL(iwl3945_rx_queue_free);
/* Convert linear signal-to-noise ratio into dB */
next reply other threads:[~2009-05-05 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 12:51 Jan Beulich [this message]
2009-05-05 17:27 ` reinette chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A00525C.76EA.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ilw@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®