From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Bryan Donlan <bdonlan@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [BISECTED REGRESSION] Xen: OOPSes on heavy block IO on 2.6.30-master
Date: Thu, 07 May 2009 22:35:50 -0700 [thread overview]
Message-ID: <4A03C4B6.5070308@goop.org> (raw)
In-Reply-To: <3e8340490905072118s6d7a4127tff932317213febb4@mail.gmail.com>
Bryan Donlan wrote:
> I've bisected this problem down to the following commit;
> unfortunately, there were some rather hairy interdependencies after
> that point, so I wasn't able to test reverting it on top of master:
> commit 93dbda7cbcd70a0bd1a99f39f44a9ccde8ab9040
> Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Date: Thu Feb 26 17:35:44 2009 -0800
>
Thanks for going to the trouble of bisecting this, but I'd just fixed
this bug :/
The patch below should fix it.
Thanks again,
J
>From f26499cadfd057e4377e92ba680e16fa7bdf9422 Mon Sep 17 00:00:00 2001
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Date: Tue, 5 May 2009 13:08:42 -0700
Subject: [PATCH] xen/i386: reserve Xen pagetables
The Xen pagetables are no longer implicitly reserved as part of the other
i386_start_kernel reservations, so make sure we explicitly reserve them.
This prevents them from being released into the general kernel free page
pool and reused.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 0e13477..801d042 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -1799,6 +1799,11 @@ __init pgd_t *xen_setup_kernel_pagetable(pgd_t *pgd,
pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE, PFN_DOWN(__pa(swapper_pg_dir)));
+ reserve_early(__pa(xen_start_info->pt_base),
+ __pa(xen_start_info->pt_base +
+ xen_start_info->nr_pt_frames * PAGE_SIZE),
+ "XEN PAGETABLES");
+
return swapper_pg_dir;
}
#endif /* CONFIG_X86_64 */
next prev parent reply other threads:[~2009-05-08 5:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 4:18 Bryan Donlan
2009-05-08 5:35 ` Jeremy Fitzhardinge [this message]
2009-05-08 6:18 ` Bryan Donlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A03C4B6.5070308@goop.org \
--to=jeremy@goop.org \
--cc=bdonlan@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®