From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755732AbZEUVgS (ORCPT ); Thu, 21 May 2009 17:36:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753315AbZEUVgG (ORCPT ); Thu, 21 May 2009 17:36:06 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:46059 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbZEUVgF (ORCPT ); Thu, 21 May 2009 17:36:05 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4A15C92A.9030300@s5r6.in-berlin.de> Date: Thu, 21 May 2009 23:35:38 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.21) Gecko/20090411 SeaMonkey/1.1.16 MIME-Version: 1.0 To: David Miller CC: linux1394-devel@lists.sourceforge.net, linux-hotplug@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, fenlason@redhat.com Subject: Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name References: <20090521.123403.13286908.davem@davemloft.net> <4A15B5FE.3070207@s5r6.in-berlin.de> <20090521.133304.10307675.davem@davemloft.net> In-Reply-To: <20090521.133304.10307675.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: > From: Stefan Richter > Date: Thu, 21 May 2009 22:13:50 +0200 > >> But I mildly disagree with the notion that the kernel can't start off >> with more qualification of the names than merely ensuring their >> uniqueness. Or the other way around: Even an entirely meaningless >> prefix would be better than "eth..", or no prefix if that's possible, >> because eth suspiciously sounds like Ethernet with which the misnamed >> RFC 2734 driver eth1394 has very little to do. > > Even the driver source file is named "ethXXX"! All of the macros > in the driver are named ETH*. The eth1394hdr looks eerily similar > to a real ethernet header except that it lacks a source MAC > address. It's addressing information plus a 16-bit (wow, why that > size huh?) protocol field. A lot like ethernet. Sure, because 1. eth1394 was initially written with an eye on how Linux Ethernet drivers look like (for quite a while it didn't implement RFC 2734), 2. by nature, RFC 2734 as an IP encapsulation can't be very different from Ethernet. As it happens, RFC 2734 indeed reuses a certain 16 bits wide protocol type field in its encapsulation header, with familar values such as 0x0800. [BTW, the rest of the struct eth1394hdr is not the encapsulation header which goes out to the wire, it's only used internally by the driver. The real on-the-wire headers are 20...28 bytes wide, depending on transaction mode and link fragmentation, and there are 4 bytes trailing data CRC.] -- Stefan Richter -=====-=-=== -=-= -==-= http://arcgraph.de/sr/