From: "Jan Beulich" <JBeulich@novell.com>
To: "Rusty Russell" <rusty@rustcorp.com.au>
Cc: "Ingo Molnar" <mingo@elte.hu>, <tony.luck@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
<linux-arch@vger.kernel.org>, <linux-kbuild@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [PATCH] reduce export symbol CRC table size on 64-bit archs
Date: Wed, 01 Jul 2009 08:00:26 +0100 [thread overview]
Message-ID: <4A4B25AA020000780000861D@vpn.id2.novell.com> (raw)
In-Reply-To: <200907011430.29524.rusty@rustcorp.com.au>
>>> Rusty Russell <rusty@rustcorp.com.au> 01.07.09 07:00 >>>
>On Tue, 30 Jun 2009 09:21:52 pm Jan Beulich wrote:
>> Since these CRCs are really only 32-bit quantities, there's no need to
>> store them in 64-bit slots. Since, however, gcc doesn't allow
>> respective initializations, asm() constructs get used to create the CRC
>> tables (and its for that reason that the patch only makes x86-64 and
>> ia64 utilize that functionality, as I can't verify this doesn't break
>> in some subtle way elsewhere).
>
>Hmm, can we change the build system to just link this in as a normal table,
>rather than use linker tricks?
>
>Then genksyms would just spit out a C file we could compile and link into final
>vmlinux.
That's going to be non-trivial, because of the ordering that's required to be
identical between the symbol and the CRC tables. Basically that would mean
that genksyms would need to look at either the assembly output or the
object file, which would further slow down the build process. Compared to
that the asm() solution in the patch sent seems more strait forward (despite
it possibly looking convoluted at the first glance).
Jan
next prev parent reply other threads:[~2009-07-01 7:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 11:51 Jan Beulich
2009-06-30 22:09 ` Ingo Molnar
2009-07-01 5:00 ` Rusty Russell
2009-07-01 7:00 ` Jan Beulich [this message]
2009-07-03 20:16 ` Michal Marek
2009-07-06 7:42 ` Jan Beulich
2009-07-09 11:14 ` Rusty Russell
2009-07-10 7:23 ` Jan Beulich
2009-07-10 14:36 ` H. Peter Anvin
2009-07-10 15:50 ` Jon Masters
2009-07-13 8:11 ` Michal Marek
2009-07-13 8:44 ` Jan Beulich
2009-07-14 10:29 ` Jon Masters
2009-07-14 10:44 ` Marco d'Itri
2009-07-14 16:43 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4B25AA020000780000861D@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®