mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paulo Marques <pmarques@grupopie.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reduce kallsyms table size on 64-bit arch-s
Date: Wed, 01 Jul 2009 17:16:11 +0100	[thread overview]
Message-ID: <4A4B8BCB.6000108@grupopie.com> (raw)
In-Reply-To: <4A4A1ED10200007800008379@vpn.id2.novell.com>

Jan Beulich wrote:
> Some architectures (the patch carries it out for x86-64) can reduce the
> kallsyms pointer table's size by half through the use of relative 32-
> bit pointers. Since the kallsyms tables get created as assembly files
> anyway, the adjustment is strait forward and only requires a little bit
> of abstraction at the consuming side.

I've been wanting to do this for a long time, so I'm really glad someone
stepped up to do it for me :)

I've reviewed the patch and it looks good. I worry that other
architectures have strange uses for addresses that might produce larger
than 32 bit offsets, especially with CONFIG_KALLSYMS_ALL, but since this
is an "opt-in" config option, I guess it's ok.

Acked-by: Paulo Marques <pmarques@grupopie.com>

> Further, independent of architecture, kallsyms_num_syms and
> kallsyms_markers[] can use 32-bit types.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

-- 
Paulo Marques - www.grupopie.com

"Who is general Failure and why is he reading my disk?"

      reply	other threads:[~2009-07-01 16:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 12:18 Jan Beulich
2009-07-01 16:16 ` Paulo Marques [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A4B8BCB.6000108@grupopie.com \
    --to=pmarques@grupopie.com \
    --cc=JBeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome