mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: commit 097041e576ee3a50d92dd643ee8ca65bf6a62e21 (fuse: Fix build error)
Date: Sat, 11 Jul 2009 12:40:32 -0500	[thread overview]
Message-ID: <4A58CE90.2070301@lwfinger.net> (raw)
In-Reply-To: <1247321214.5615.6.camel@heimdal.trondhjem.org>

Trond Myklebust wrote:
> Hi Linus
> 
> Please revert this commit. Instead of fixing the compile problem, it
> adds a new dependency on CONFIG_BLOCK to both NFS and FUSE. Neither one
> of them has such a dependency today, nor is there a reason to introduce
> one. 
> 
> The correct fix should rather be to move the definitions of BLK_RW_SYNC
> and BLK_RW_ASYNC into backing-dev.h as per the patch below.
> 
> Cheers
>   Trond

I understand that my "fix" was wrong. I'm sure that Linus is on top of
this, but your patch must be added before reverting 097071e5,
otherwise a new build failure is introduced that might be encountered
when bisecting. Why not undo my changes and add yours in a single patch?

Larry


  reply	other threads:[~2009-07-11 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-11 14:06 Trond Myklebust
2009-07-11 17:40 ` Larry Finger [this message]
2009-07-11 18:19 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A58CE90.2070301@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome